Skip to content

Add AES HW encryption for NUCLEO_F756ZG in mbedtls #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2017

Conversation

adustm
Copy link
Member

@adustm adustm commented Apr 11, 2017

Description

Enable HW acceleration for AES ECB + CBC on STM32F756ZG
aes_alt.c is compatible between STM32F4 and F7. Only defines have been necessary.
is #3954

Status

READY

Steps to test or reproduce

To test this feature, you have to modify TESTS/mbedtls/selfttest/main.cpp in order to call aes self test:
add:
#include "mbedtls/aes.h"
then

#if defined(MBEDTLS_AES_C)
MBEDTLS_SELF_TEST_TEST_CASE(mbedtls_aes_self_test)
#endif

then

#if defined(MBEDTLS_AES_C)
    Case("mbedtls_aes_self_test", mbedtls_aes_self_test_test_case),
#endif

@adustm
Copy link
Member Author

adustm commented Apr 11, 2017

@sg-

@adustm
Copy link
Member Author

adustm commented Apr 25, 2017

bump, ready to merge ?

@adustm
Copy link
Member Author

adustm commented May 15, 2017

@0xc0170
The PR is approved by Ron. Is there anything blocking here ?
Kind regards

@0xc0170 0xc0170 merged commit 9b37e52 into ARMmbed:mbed-os-workshop-17q2 May 15, 2017
@adustm adustm deleted the STM_aes_f756zg branch May 29, 2017 08:39
@adustm
Copy link
Member Author

adustm commented Jun 23, 2017

Hello @adbridge @0xc0170
Any idea when this will be integrated in the master branch ?

cc @screamerbg

@adbridge
Copy link
Contributor

@adustm Unfortunately we have been advised by @sbutcher-arm that all TLS PRs have to be approved by @yanesca before they can be merged. We are thus waiting on him.

@adbridge
Copy link
Contributor

@adustm This also needs to be redirected to master .

@yanesca
Copy link
Contributor

yanesca commented Jun 27, 2017

@adustm It looks good to me, but just to be thorough I would like to have a look at it after it is redirected to master too.

@adustm
Copy link
Member Author

adustm commented Jun 28, 2017

@yanesca @adbridge no problem to accept the review process
@yanesca just to let you know : AES for STM32F756 is 100% compatible with aes for STM32F439.
As aes was already merged in mbed-os, the merge of current PR should only add the AES_ALT in the mbedtls_device.h.

Kind regards
Armelle

@yanesca
Copy link
Contributor

yanesca commented Jun 28, 2017

@adustm Thank you for reminding me! My main reason for wanting to have a look at it after rebase is, that this PR has been already merged and I github doesn't let me approve it. I just would like to give a formal approval and I hope I can do it after the rebase when we have an open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants