-
Notifications
You must be signed in to change notification settings - Fork 3k
Replace deprecated import and correct typo in c_blob_mbed.tmpl #4167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- critical.h is deprecated, replaced with "platform/mbed_critical.h" - typo corrected
@0x6d61726b Could you update the files in this repo that were generated by this template to reflect this change? |
shall "mbed_critcal.h" also be updated to "platform/mbed_critical.h"? |
Where would you be updating that? You already updated the template to do that. |
Maybe there is a misunderstanding. What do you mean by:
I do not have write permission to the ARMmbed/mbed-os repo. |
You would update them in this PR, as another commit. |
Also, could you change the title of this PR to be more meaningful? Something like: Replace deprecated import and correct typo in c_blob_mbed.tmpl |
@0x6d61726b Can you please sign https://developer.mbed.org/contributor_agreement/ ? |
I already signed the Contributor Agreement |
/morph test |
Sorry for the comment spam y'all, debugging an issue with the bot. /morph test |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Code/Comments improvement
Description