Skip to content

Replace deprecated import and correct typo in c_blob_mbed.tmpl #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Replace deprecated import and correct typo in c_blob_mbed.tmpl #4167

merged 1 commit into from
Apr 19, 2017

Conversation

0x6d61726b
Copy link
Contributor

Code/Comments improvement

Description

  • critical.h is deprecated, replaced with "platform/mbed_critical.h"
  • typo corrected

- critical.h is deprecated, replaced with "platform/mbed_critical.h"
- typo corrected
@theotherjimmy theotherjimmy requested a review from c1728p9 April 11, 2017 19:15
@theotherjimmy
Copy link
Contributor

@0x6d61726b Could you update the files in this repo that were generated by this template to reflect this change?

@0x6d61726b
Copy link
Contributor Author

shall "mbed_critcal.h" also be updated to "platform/mbed_critical.h"?

@theotherjimmy
Copy link
Contributor

Where would you be updating that? You already updated the template to do that.

@0x6d61726b
Copy link
Contributor Author

Maybe there is a misunderstanding. What do you mean by:

Could you update the files in this repo that were generated by this template to reflect this change?

I do not have write permission to the ARMmbed/mbed-os repo.

@theotherjimmy
Copy link
Contributor

You would update them in this PR, as another commit.

@theotherjimmy
Copy link
Contributor

Also, could you change the title of this PR to be more meaningful? Something like: Replace deprecated import and correct typo in c_blob_mbed.tmpl

@0x6d61726b 0x6d61726b changed the title Update c_blob_mbed.tmpl Replace deprecated import and correct typo in c_blob_mbed.tmpl Apr 11, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2017

@0x6d61726b
Copy link
Contributor Author

I already signed the Contributor Agreement

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2017

/morph test

@bridadan
Copy link
Contributor

Sorry for the comment spam y'all, debugging an issue with the bot.

/morph test

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 21

All builds and test passed!

@sg- sg- merged commit 247238d into ARMmbed:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants