Fix include paths for Windows builds #4170
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
|
rebuilding the Cam-CI. It failed from java exception. |
|
@RdaZhongyao could you test? |
|
My local build passed with GCC compiler. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Apr 12, 2017
|
retest uvisor |
|
@0xc0170 You could just merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descritpion
Resolves #3940
How to reproduce
The issue mentioned above can me sumarized as:
This does not work:
This works:
mbed compile --source .Both should work.
Why does this fail?
The include directories passed to
--sourceare added as-is to the listof include directories. GCC, and possibly other compilers, on Windows
does not like the path
./and will ignore it when searching for headerfiles.
New behavior
Remove trailing
/s before appending include paths to when scanningresources.
Testing