support for ubirch boards #4183
Conversation
|
@thinkberg Can you please sign https://developer.mbed.org/contributor_agreement/ ? Please rebase (remove the merge commits to update this patch), to be on top of the current master. |
|
I hope the modifications are now as expected. |
|
retest uvisor |
| @@ -0,0 +1,113 @@ | |||
| /* mbed Microcontroller Library | |||
| * Copyright (c) 2006-2013 ARM Limited | |||
There was a problem hiding this comment.
be careful when copying this, year should be 2017 as it's new file
targets/targets.json
Outdated
| "UBRIDGE": { | ||
| "core": "Cortex-M4F", | ||
| "supported_toolchains": ["ARM", "GCC_ARM", "IAR"], | ||
| "extra_labels": ["Freescale", "MCUXpresso_MCUS", "K82F", "UBRIDGE"], |
There was a problem hiding this comment.
UBRIDGE should not be needed
targets/targets.json
Outdated
| "USENSE": { | ||
| "core": "Cortex-M0+", | ||
| "supported_toolchains": ["ARM", "GCC_ARM", "IAR"], | ||
| "extra_labels": ["Freescale", "MCUXpresso_MCUS", "KL82Z", "USENSE"], |
There was a problem hiding this comment.
USENSE here should not be needed
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
@thinkberg Please look at failures (the link provided in the test result above), there are failures for usense and k82 platform |
|
@thinkberg Have you had a chance to look at these failures? |
|
An issue is that if the RTC feature is not enabled, the problems occur. I have enabled rtc as the current version of usense does have an rtc. |
|
@thinkberg This PR contains commits that are currently on master. Could you rebase to resolve this? |
|
I did a rebase, I hope this is resolved now. |
|
It still looks like things went wrong. It looks like you started at 4c0ccf0, but you have a tonne of commits before then. I wonder what went wrong. Did you do |
|
Strange, how about I fork a fresh copy and add my changes fresh? |
|
If you'll let me, I can fix the current PR. Would you like me to do that for you? |
|
Sure :-) feel free i take any help.
Thanks,
Leo.
…--
Matthias L. Jugel - Idea Transporter
@thinkberg | http://thinkberg.com | +49 151 2910 9505
There are two kinds of fool, one says "this is old and therefore good"
and the other says "this is new and therefore better". John Brunner (The Shockwave Rider)
On 12. May 2017 at 20:52:34, Jimmy Brisson ***@***.******@***.***)) wrote:
If you'll let me, I can fix the current PR. Would you like me to do that for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#4183 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAQ37VRbv7d_QJqa_bMcy5tGcrJMGclUks5r5KpygaJpZM4M8ZQC).
|
|
@thinkberg I have been digging through the history now for a few minutes. Here's what I think happened:
I think that process happened 8(!) times. |
|
Okay, learned something! Thanks.
Leo.
…--
Matthias L. Jugel - Idea Transporter
@thinkberg | http://thinkberg.com | +49 151 2910 9505(tel:+49%20151%202910%209505)
There are two kinds of fool, one says "this is old and therefore good"
and the other says "this is new and therefore better". John Brunner (The Shockwave Rider)
On 12. May 2017 at 21:31:35, Jimmy Brisson ***@***.******@***.***)) wrote:
@thinkberg(https://github.com/thinkberg) I have been digging through the history now for a few minutes. Here's what I think happened:
you correctly rebased onto master (yeah!)
you tried to push to github
it complained, telling you to pull first (you should not do this after a rebase)
you pulled, and merged the new series with the old (duplicating the commits, with different hashes)
you pushed this duplicated history to github.
I think that process happened 8(!) times.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#4183 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAQ37R86Dy-BRnEowRp8H9UnWINVGAPpks5r5LOXgaJpZM4M8ZQC).
|
|
Instead, the process you should go through is:
That's it :) |
|
I don't think that I will forget this... ;-)
Leo.
…--
Matthias L. Jugel - Idea Transporter
@thinkberg | http://thinkberg.com | +49 151 2910 9505(tel:+49%20151%202910%209505)
There are two kinds of fool, one says "this is old and therefore good"
and the other says "this is new and therefore better". John Brunner (The Shockwave Rider)
On 12. May 2017 at 21:44:45, Jimmy Brisson ***@***.******@***.***)) wrote:
Instead, the process you should go through is:
rebase
force push to github
That's it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#4183 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAQ37ZbqSoIT8Rybzs8gGXjij580cSAwks5r5LatgaJpZM4M8ZQC).
|
|
Just a moment, wrong branch |
|
Dang, now I can't push because this PR is closed. |
|
Re-opened at #4315 |
|
What now?
…--
Matthias L. Jugel - Idea Transporter
@thinkberg | http://thinkberg.com | +49 151 2910 9505(tel:+49%20151%202910%209505)
There are two kinds of fool, one says "this is old and therefore good"
and the other says "this is new and therefore better". John Brunner (The Shockwave Rider)
On 12. May 2017 at 22:19:57, Jimmy Brisson ***@***.******@***.***)) wrote:
Dang, now I can't push because this PR is closed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(#4183 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAQ37aeqsCkR8F5m63d5PEJEQRFEps5Sks5r5L7tgaJpZM4M8ZQC).
|
|
I re-opened the PR, with the new history. I hope it's correct. |
|
You should still have a copy of the old history on your machine. That was a terrible mistake on my part. I did |
|
Should I do something? |
|
Could you take a look at #4315 And tell me if I missed anything? |
Description
Add support for our ubirch boards. UBRIDGE is a board with a K82F, GSM modem and some other parts that is programmed via USB (using an adapter board based on a K20DX). USENSE is a small form factor low-power sensor module with a KL82z MCU and sub-1GHz RF.
The changes include a fix in the debug uart settings, allowing for boards without external oscillator. It also enables the TRNG in the K_82 MCU for mbed.
Status
IN DEVELOPMENT
Migrations
NO
Todos