Skip to content

USB: Add support for STM32F446 #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adbridge
Copy link
Contributor

This PR adds USB support for the STM32F446

@adbridge
Copy link
Contributor Author

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 67

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2017

@adustm
Copy link
Member

adustm commented Apr 24, 2017

Hello @adbridge
We have thought of a new way of handling the USB support outside of the Feature library.
We would be in favor of the PR #3988 way of implementing.
Is there any reason why you implemented it another way ?
I can understand that it does not look very clear, sorry for this.

Kind regards
Armelle

@adbridge
Copy link
Contributor Author

adbridge commented Apr 24, 2017

@adustm Hi, this was a direct port of the solution that was submitted on the mbed org site (https://developer.mbed.org/users/mbed_official/code/USBDevice/rev/7662d9ed5011). It was submitted quite sometime ago so may account for why it isn't the optimal solution now. We have been tidying up the PRs there and trying to make sure all of them are back ported here. If you'd like to do this another way, please feel free to submit an alternative. We can close this in favour of a new approach, however this is the approach currently now in the mbed 2 repo (USBDevice).
Regards, Anna

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2017

We would be in favor of the PR #3988 way of implementing.

We can close this in favour of a new approach, however this is the approach currently now in the mbed 2 repo (USBDevice).

+1, lets close this one and focus on #3988

@0xc0170 0xc0170 closed this Apr 24, 2017
@adbridge adbridge deleted the usb_STM32F446 branch May 4, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants