-
Notifications
You must be signed in to change notification settings - Fork 3k
USBHOST hub support for TARGET_STM #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USBHOST hub support for TARGET_STM #4231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just style issues. How this can be tested? Any tests that should be written?
dev_connected = true; | ||
int ret=host->interruptRead(dev, int_in, report, len_listen, false); | ||
MBED_ASSERT((ret==USB_TYPE_OK) || (ret ==USB_TYPE_PROCESSING) || (ret == USB_TYPE_FREE)); | ||
if ((ret==USB_TYPE_OK) || (ret ==USB_TYPE_PROCESSING)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls fix formatting for these 2 if () { }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree , I ll update soon.
if ((&hubs[k] == usb_msg->hub_parent) && (hub_in_use[k])) | ||
hub_unplugged=false; | ||
} | ||
} else hub_unplugged = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fomrmatting here and line 93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree I ll update soon
and connection from hub are sent from usb task. A connection on an hub port can be sent , after irq disconnection from root hub.
In case interrupt reports error, call back can send interrupt request again.
- set_state specific - speed init
add warn small speed device are connected on hub
ca3b20d
to
c4a0497
Compare
For the test , it is manuall test and it relies on main.cpp present in https://developer.mbed.org/teams/ST/code/Nucleo_usbhost/
plug/unplug the different elements (i.e plug usb stick , un-plug hub, plug hub , plug mouse, plug usbstick , un-plug mouse, un-plug stick , plug stick, plug mouse, un-plug hub ...) |
Description
This list of commit brings:
Status
READY