NSAPI - Don't send trailing garbage in DNS queries #4274
Conversation
Observed during investigation of ARMmbed#4246 - DNS queries sent the entire buffer, not just the bit filled in. Inefficient, especially for 6LoWPAN, and a security hole - the trailing data could be previously-used heap.
|
Looks good to me |
|
/morph test-nightly |
|
Heh, we found this too yesterday looking at a similar issue. Seems like you beat us to the punch. It seems some DNS servers also reject the query if the size of the packet does not match what's in the header. Should resolve #3926 |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
I don't think that's @kjbracey-arm's fault. @studavekar Any idea on what could have caused this? |
|
MAX32625MBED device was not been listed by mbedls, Device was in bad state. mbedgt should detect and run the test now. |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
The arch pro has been having issues in CI with the flash test. @bridadan is already on it, it may just be that the board's flash has been exhausted. |
|
Quick update on the arch pro. @studavekar was able to reproduce it and the error is detailed in #4288. @0xc0170 mentions there that he thinks we should disable the flash capability for the arch pro until we can fix it, so I raised PR #4298. When that gets in hopefully this PR can move forward. |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
restarting /morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Observed during investigation of
#4246 - DNS queries sent
the entire buffer, not just the bit filled in.
Inefficient, especially for 6LoWPAN, and a security hole - the trailing
data could be previously-used heap.