Skip to content

LPC4088: add "LPC4088Code.binary_hook" to the white list of the embit… #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2017

Conversation

netzimme
Copy link
Contributor

@netzimme netzimme commented May 8, 2017

Add "LPCTargetCode.lpc_patch" to the white list of the embitz, gnuarmeclipse and makefile exporter.

Description

With this changes it is possible to export the programs for LPC4088 as embitz, gnuarmeclipse or makefile project.

@netzimme
Copy link
Contributor Author

netzimme commented May 8, 2017

@sg- sg- requested a review from theotherjimmy May 9, 2017 03:20
@theotherjimmy
Copy link
Contributor

theotherjimmy commented May 9, 2017

You added LPC4088Code.binary_hook to the white-list. Could you update the commit message to reflect that?

I should run /morph export-build after you do

@theotherjimmy theotherjimmy changed the title LPC4088: add "LPCTargetCode.lpc_patch" to the white list of the embit… LPC4088: add "LPC4088Code.binary_hook" to the white list of the embit… May 9, 2017
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. This is the correct way to enable exports for these targets.

@netzimme
Copy link
Contributor Author

netzimme commented May 9, 2017

Change the title of the patch.

Thanks

@theotherjimmy
Copy link
Contributor

@netzimme did you push the changed patch?

@netzimme
Copy link
Contributor Author

netzimme commented May 9, 2017

Now I push the change.

@theotherjimmy
Copy link
Contributor

Hmmmmm.... it seems that you changed the title then merged the two together. I don't think that's what you intended to do.

@theotherjimmy
Copy link
Contributor

There we go! That's correct.

@netzimme
Copy link
Contributor Author

netzimme commented May 9, 2017

Fine :-)

@theotherjimmy
Copy link
Contributor

/morph export-build

@mbed-bot
Copy link

mbed-bot commented May 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 28

All exports and builds passed!

@theotherjimmy
Copy link
Contributor

@netzimme Are the executables created from theses new exports flashing correctly?

@theotherjimmy
Copy link
Contributor

Please don't show me mbed test output. That does not impact the exporters.

@netzimme
Copy link
Contributor Author

Hello @theotherjimmy

I did test the following exporters with compile/flashing/debugging on the target with the Segger/J-Link probe. I have noticed no problems.

eclipse_gcc_arm
embitz
gcc_arm
gnuarmeclipse
make_gcc_arm
vscode_gcc_arm

@theotherjimmy
Copy link
Contributor

Awesome! Thanks a bunch @netzimme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants