Dev stm32 hal f1 v1.5.0 #4296
Merged
Dev stm32 hal f1 v1.5.0 #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAL V1.1.0 LL V1.1.0 CMSIS V4.2.0
The states definition in HAL have changed so F1 driver needs updates accordingly (as done previously on other families)
|
retest uvisor |
bcostm
reviewed
May 11, 2017
|
|
||
| #define TIM_MST_RESET_ON __TIM4_FORCE_RESET() | ||
| #define TIM_MST_RESET_OFF __TIM4_RELEASE_RESET() | ||
| #define TIM_MST_RESET_ON __HAL_RCC__TIM4_FORCE_RESET() |
There was a problem hiding this comment.
There are 2 underscores between RCC and TIM4.
bcostm
reviewed
May 11, 2017
| #define TIM_MST_RESET_ON __TIM4_FORCE_RESET() | ||
| #define TIM_MST_RESET_OFF __TIM4_RELEASE_RESET() | ||
| #define TIM_MST_RESET_ON __HAL_RCC__TIM4_FORCE_RESET() | ||
| #define TIM_MST_RESET_OFF __HAL_RCC__TIM4_RELEASE_RESET() |
|
@bcostm thanks a lot for the review - PR updated with a fix |
I dont see any commits updated after the review? forgot to push? |
|
@0xc0170 thx ! I actually encountered a proxy issue when pushing the commit but missed the error msg |
|
/morph test |
0xc0170
approved these changes
May 11, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
ready for merge
release-version: 5.4.6
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update of the STM32 F1 STM32 cube (SDK)
Status
READY
Tests
The OS2 and OS5 non-regression tests were run successfully in our test bench.