Fix NVIC_SetVector type in HAL for MAX32630FTHR #4308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the irq_handler parameter of NVIC_SetVector from a function pointer to a uin32_t so it matches the cmsis specification. This prevents the following problem from occurring in RTX5 when building for IAR: The error: Error[Pe167]: argument of type "void (*)(void)" is incompatible with parameter of type "uint32_t".
theotherjimmy
changed the title
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
May 12, 2017
bulislaw
approved these changes
May 12, 2017
pan-
approved these changes
May 12, 2017
|
I'm guessing because the hardware definition is 32-bits. Perhaps in some weird world it could end up possible to have the compiler incorrectly emitting 64-bit pointers? Then the nvic taking in 32-bits would actually error. Though at that point you'd probably notice something big was wrong anyways. |
|
Had a compiler (online) fault with uint32_t invalid pointer type nvic_setvector...looking around net seems this was changed a year or so ago but the onine compiler doesnt have the cast ...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the irq_handler parameter of NVIC_SetVector from a function
pointer to a uin32_t so it matches the cmsis specification. This
prevents the following problem from occurring in RTX5 when building
for IAR:
The error: Error[Pe167]: argument of type "void (*)(void)" is incompatible
with parameter of type "uint32_t".
Based on b5db960 from the CMSIS_5 branch.