Fix RAM vector table for NCS36510 #4310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
|
retest uvisor |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
bulislaw
approved these changes
May 12, 2017
pan-
requested changes
May 12, 2017
|
@pan- Good catch! This came most probably from https://github.com/c1728p9/mbed-os/blob/d74e219685f1e55a6a01eb4bb7d4f0e3e46759da/targets/TARGET_ONSEMI/TARGET_NCS36510/device/NCS36510.h#L76 (it was set to 36) . As you quoted, the reference manual defines 35. |
Fix the ram address of the vector table on the NCS36510. Also reserve space for it in the linker scripts.
c1728p9
force-pushed
the
fix_ncs36510_vector_table
branch
from
d74e219 to
5cf2255
Compare
|
Good catch @pan-. I updated the comment to reflect the correct number of interrupt vectors. I kept the size the same to keep 8 byte alignment. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
pan-
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ram address of the vector table on the NCS36510. Also reserve space for it in the linker scripts.
This is based on 94a0256 from the CMSIS_5 branch.