Skip to content

Remove unwanted (and unused anymore) NRF5_SDK13 BLE port #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2017

Conversation

nvlsianpu
Copy link
Contributor

Description

Remove unwanted and unused anymore NRF5_SDK13 BLE port.
It was omited in #4245.

cc @pan-

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2017

retest uvisor

@AnotherButler
Copy link
Contributor

@nvlsianpu Thanks for the PR.

Also, we're recommending all contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. To match this format, please delete the period from the end of your subject line. Thanks for your contributions.

@nvlsianpu nvlsianpu changed the title Remove unwanted (and unused anymore) NRF5_SDK13 BLE port. Remove unwanted (and unused anymore) NRF5_SDK13 BLE port May 17, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

/morph test

@0xc0170 0xc0170 assigned pan- and unassigned pan- May 17, 2017
@0xc0170 0xc0170 requested a review from pan- May 17, 2017 09:51
@mbed-bot
Copy link

Result: NOT_BUILT

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

@bridadan CI restart? I noticed 5 jobs resulted the same as the one above - did not built

@bridadan
Copy link
Contributor

@0xc0170 yeah go ahead, not sure what the happened there.

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 251

All builds and test passed!

@pan-
Copy link
Member

pan- commented May 23, 2017

test ble

{ 
    "targets": ["NRF51_DK", "NRF52_DK"],
    "toolchains": ["GCC_ARM", "ARM"]
}

@theotherjimmy
Copy link
Contributor

@pan- where's the IAR testing?

@pan-
Copy link
Member

pan- commented May 23, 2017

@theotherjimmy Until Oulu CI is fixed, there will be no BLE testing with IAR on PR tests; but there is with nighties.
This PR is just about removing dead code, it shouldn't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants