Skip to content

Fix for blockwise observation failure #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2017
Merged

Fix for blockwise observation failure #4332

merged 2 commits into from
May 26, 2017

Conversation

yogpan01
Copy link
Contributor

Description

This commit includes

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

Detailed Changelog available here PelionIoT/mbed-coap@v4.0.3...v4.0.4

Fix for blockwise observation failure
95b657b 
This commit includes
 - Fix for ARMmbed/mbed-client#481
 - Detailed Changelog available here PelionIoT/mbed-coap@v4.0.3...v4.0.4
@yogpan01
Copy link
Contributor Author

@0xc0170 @adbridge FYI. Can you please take this for next mbedOS RC ?

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

/morph test-nightly

adbridge
adbridge requested changes May 17, 2017
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

features/FEATURE_COMMON_PAL/mbed-coap/source/sn_coap_protocol.c Outdated
stored_blockwise_msg_temp_ptr->coap_msg_ptr->options_list_ptr &&
stored_blockwise_msg_temp_ptr->coap_msg_ptr->options_list_ptr->observe != COAP_OBSERVE_NONE) {
remove_from_the_list = false;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remove_from_list was initialised to true , the else block would be unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mbed-bot
Copy link

Result: NOT_BUILT

Your command has finished executing! Here's what you wrote!

/morph test-nightly

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 248

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented May 18, 2017

/morph test-nightly

@JanneKiiskila JanneKiiskila mentioned this pull request May 18, 2017
Closed
@adbridge
Copy link
Contributor

Again looks like nightly passed but didn't report results!

@adbridge
Copy link
Contributor

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 300

Test failed!

@bridadan
Copy link
Contributor

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 314

Example Build failed!

@adbridge
Copy link
Contributor

@pan- any ideas ?

04:25:48 Compiling mbed-os-example-ble-LED for NRF52_DK, IAR
04:26:13 [ERROR] Error[Lt006]: Incompatible object(s): DblCmpLe.o(m7M_tlv.a) and 18 other
04:26:13           objects use VFP instructions incompatible with FPv4 (derived from
04:26:13           attributes)

@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented May 24, 2017 •
edited
Loading

When is this coming in?
@adbridge @0xc0170
This is a bug fix that would need to get into an mbed OS 5.4.x (I was hoping 5.4.6).

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 330

All builds and test passed!

sg- added a commit that referenced this pull request May 26, 2017
@sg-
Merge pull request #4332 from yogpan01/master
ede7762 
Fix for blockwise observation failure
@sg- sg- merged commit ede7762 into ARMmbed:master May 26, 2017
@yogpan01 yogpan01 mentioned this pull request Jun 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.4.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yogpan01 @0xc0170 @mbed-bot @adbridge @bridadan @JanneKiiskila @sg-