Adjust Thread interface connect timeout #4333
Conversation
|
@mikter , @SeppoTakalo , @karsev , @terhei would you also please check? |
| #else | ||
| // static link configuration is not used, wait for commissioning to happen | ||
| int32_t count = connect_semaphore.wait(osWaitForever); | ||
| #endif |
There was a problem hiding this comment.
@SeppoTakalo @kjbracey-arm I have issue with the way interface is working differently now.
Thread is meant to be fire and forget. it will get the internet after weeks or by attaching to existing network in couple seconds or forming own network.
when End devices don't find parent they will not get the network in 30 seconds, but will get when some router becomes available --> should wait forever
Should we have method to identify when we have local connectivity or global connectivity.
And this should delay only to the point when we have configuration and stack is initialised correctly
There was a problem hiding this comment.
A new PR will be be created to solve connectivity issue. In a meanwhile agreed with @SeppoTakalo and @mikter that Thread should wait for connectivity for ever in all cases.
Thread device needs to wait for connectivity: -routers will create new network and get local connectivity -end device will get connectivity once attached to existing network -devices without network settings gets connectivity once commissioned and attached to network
artokin
force-pushed
the
thread_interface_timeout
branch
from
5c0ffd9 to
28a6fa1
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@adbridge this would be needed into mbed OS 5.5. Can you tag to the release. Thanks |
Description
Thread device needs to wait for connectivity:
This PR removes connection timeout from Thread interface connect method. Then end devices and devices without network configuration settings will try connection for ever. This change does not affect to routers as they will get local connectivity.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Related PRs
Todos
Steps to test or reproduce