Reduce size of heap block device test #4367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
|
FYI @geky |
|
Oh, did we actually want to reduce the block size instead? |
|
Yup. Thanks for reminding me! |
to fit into smaller targets
theotherjimmy
force-pushed
the
reduce-heap-block-device
branch
from
909b21a to
a56f874
Compare
|
@geky Fixed |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Doesn't make sense, must be some instability. /morph test |
6 tasks
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@0xc0170 that can be merged now :) |
|
This is reliant on #4317 and a couple of others that have only been marked for 5.5.0 and thus should not be backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some small targets that barely fit this test as it is, so I reduced
the size of this test to fit easily in these small targets.
Status
Ready
Todos