Allow target attribute overrides in app config and pick toolchain with default_toolchain #4387
Conversation
|
Alternative implementation of #4371 |
|
Wow that failed fast. |
theotherjimmy
force-pushed
the
override-target-attrs
branch
from
0a15635 to
e0612f0
Compare
|
Travis still fails |
|
That travis log is not for the current commit. It's for 862fddc, the current commit is e0612f0. |
Thats correct. I restarted it but does not pick up the latest one. Can you please rebase/amend to restart it? |
|
Trying to retrigger travis... |
theotherjimmy
force-pushed
the
override-target-attrs
branch
2 times, most recently
from
4abe922 to
8ff08d1
Compare
|
Ah, I forgot to push. That was the problem. |
|
Documentation submitted. |
theotherjimmy
force-pushed
the
override-target-attrs
branch
from
8ff08d1 to
18cb953
Compare
|
@sg- ARM should now only be ARM, and uARM only uARM. |
|
@theotherjimmy looks like this also needs a rebase now |
|
Yes it does. |
theotherjimmy
force-pushed
the
override-target-attrs
branch
from
18cb953 to
e001a3a
Compare
|
retest uvisor |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild Prep failed! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
|
@theotherjimmy Fails for 2 targets, all toolchains, with the following message It's related to bootloader example. I firstly thought it was CI failure, but no it is example build failure for those targets that support the bootloader |
theotherjimmy
force-pushed
the
override-target-attrs
branch
from
e001a3a to
9324eb8
Compare
|
I had an ordering wrong. shakes fist at sky darn you imperative paradigm! |
theotherjimmy
force-pushed
the
override-target-attrs
branch
from
9324eb8 to
4e3591b
Compare
|
/morph test |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
force-pushed
the
override-target-attrs
branch
from
4e3591b to
9277c6e
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
The two commits in this PR do independent things:
First
We currently do not allow a user to override noncumulative attributes in the app
config. Attempting to override
target.core,target.default_libortarget.default_toolchainwill error out with "Atempted to override undefinedparameter".
Instead, lets allow user to do this.
Second
This commit delays evaluation of the build profiles until after the app config has had a chance to override things.
TODO