Deprecate config store and related libraries #4388
Conversation
|
/morph test |
| @@ -0,0 +1 @@ | |||
| * | |||
There was a problem hiding this comment.
I'm actually not 100% sure if this will work, but let's hope so.
There was a problem hiding this comment.
I copied this file from mbed-os\features\unsupported so hopefully it works
|
@bridadan We need to run tests to verify that what you hope works actually works right? |
|
@theotherjimmy yep, the test that's been kicked off should confirm that |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
(it worked) 😄 |
| @@ -873,6 +875,7 @@ typedef struct _ARM_DRIVER_CFSTORE | |||
|
|
|||
|
|
|||
|
|
|||
| MBED_DEPRECATED_SINCE("mbed-os-5.5", "CFSTORE replace by the fat filesystem driver.") | |||
There was a problem hiding this comment.
From comments I field on developer.mbed.org we get criticized for our vague messages when deprecated is used. In this case, not sure what a filesystem driver is or where to look for one. Can we add some specific actions such as use: class obj
| @@ -288,6 +289,8 @@ typedef struct FlashJournal_t { | |||
| * } | |||
| * \endcode | |||
| */ | |||
| MBED_DEPRECATED_SINCE("mbed-os-5.5", "FlashJournal is deprecated. " | |||
| "Use a BlockDevice or filesystem instead") | |||
| @@ -88,6 +89,8 @@ class StorageVolumeManager; /* forward declaration */ | |||
|
|
|||
| class StorageVolume { | |||
| public: | |||
| MBED_DEPRECATED_SINCE("mbed-os-5.5", "StorageVolume is deprecated. " | |||
| "Use a BlockDevice for volumes instead") | |||
There was a problem hiding this comment.
Is the new MBR class needed here? @geky
There was a problem hiding this comment.
Yeah MBRBlockDevice is a good replacement. 👍
| @@ -161,6 +164,8 @@ class StorageVolume { | |||
|
|
|||
| class StorageVolumeManager { | |||
| public: | |||
| MBED_DEPRECATED_SINCE("mbed-os-5.5", "StorageVolumeManager is deprecated. " | |||
| "Use a BlockDevice to manage volumes instead") | |||
There was a problem hiding this comment.
Is the new MBR class needed here? @geky
There was a problem hiding this comment.
Yeah MBRBlockDevice is a good replacement. 👍
|
@geky Can we please get the comments updated asap as this will be required for 5.5. Thanks |
|
Can we also deprecate https://github.com/ARMmbed/mbed-os/tree/master/hal/storage_abstraction as part of this patch? |
c1728p9
force-pushed
the
deprecate_config_store
branch
from
15a38ba to
6a3bc47
Compare
|
Comments are updated. I also deprecated https://github.com/ARMmbed/mbed-os/tree/master/hal/storage_abstraction, but this causes deprecation warnings even config store isn't used. If this is a problem then comment here and I'll revert the storage_abstraction changes. |
|
@c1728p9 That seems like a Bad Thing™. Could you find a way to not emit spurious warnings? |
Deprecate configuration-store, flash-journal and storage-volume-manager for the 5.5 release. Also disable the storage tests.
c1728p9
force-pushed
the
deprecate_config_store
branch
from
6a3bc47 to
58041a2
Compare
|
I removed the deprecation macro and replaced it with a comment. |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Deprecate configuration-store, flash-journal and storage-volume-manager for the 5.5 release. Also disable the storage tests.