Proper fix for 1fa30b7403176349557d6aea2f02a2075aa6f03b

[sg-]

For reference

[0xc0170]

How are these 2 files related? MBR should not use one letter words in the types, not clear what is the intention.

To the realtek file, it should be fine (not saying it's correct to have those types) as long as it does not get included to a user space (only within their driver, no exposure via header files) ?

[0xc0170]

cc @Archcady

[0xc0170]

@miklis @tommikas CI jenkins not reporting status?

[0xc0170]

@miklis @tommikas CI jenkins not reporting status?

It reported but took to long and the failure seems a glitch? Restarted

[tommikas]

@0xc0170 The delay was because for some reason Jenkins hadn't created a job for the PR. @miklis triggered a rescan manually, which started the job.

The job then failed because one of the CI devices had had a flash failure and dropped into maintenance mode. It's back in use again so tests should be passing.

[sg-]

The problem is text replacement for

#define u32 uint32_t
union {
    uint32_t uint32_t
}

#define for types is no bueno IMO.

[sg-]

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 452

All builds and test passed!

[Archcady]

The changes in basic_types.h looks fine, thanks.