Fix typo that used 16kB for stack. #4493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intend is to use 2kB for stack, not 16kB, but the divide operand has been forgotten here.
0xc0170
approved these changes
Jun 7, 2017
sg-
approved these changes
Jun 7, 2017
|
retest uvisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent is to use 2kB for stack, not 16kB, but the divide operand
has been forgotten here.
Description
During a CMSIS2/RTX2 work this typo has appeared in our timer. Caused RAM usage to jump 14kB up.
Status
READY
Should be included in 5.5 RC2