Skip to content

Disable error trapping for mbed 2 builds #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jun 8, 2017

To maintain backwards compatibility, keep error trapping turned off on mbed 2 builds.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I believe this makes sense as I caught exactly this today with mbed 2 tests, that used to do printf or similar techniques from interrupts (we did not have any other options back then)

To maintain backwards compatibility keep error trapping turned off
for mbed 2 builds.
@c1728p9 c1728p9 force-pushed the disable_2_error_trapping branch from 20cfe48 to 018955c Compare June 8, 2017 21:54
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2017

/morph test

@pan-
Copy link
Member

pan- commented Jun 9, 2017

Would it be interesting to fix mbed 2 tests which use printf in interrupts ? Should we track this as an mbed os 2 issue ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2017

Would it be interesting to fix mbed 2 tests which use printf in interrupts ? Should we track this as an mbed os 2 issue ?

Yes. mbed 2 tests are unsupported, so once we bring them back we should

@mbed-bot
Copy link

mbed-bot commented Jun 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 514

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants