Skip to content

NRF52840: enabled SdBlockDevice capability #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

kegilbert
Copy link
Contributor

NOTE This is a duplicate PR of #4478. There was a merge conflict after some recent changes were pushed up to master. I used the GitHub fix conflicts shiny button which created a merge commit. I wasn't able to undo it in a clean way, so I moved the rebase to this branch.


Rebase against master for: #4088

Smaller chunk of the Workshop branch additions: #4412

Feel free to add in however else should be a reviewer @c1728p9

Changes from the original commit to targets/TARGET_NORDIC/TARGET_NRF5_SDK13/spi_api.c have been removed as the following commit removed those files as orphans:
708dd47

nvlsianpu and others added 3 commits June 8, 2017 17:31
[NRF52840]: fix SdBlockDevice capability device by disabling SPI_ASYNC mode.
…cating that change to allow builds on the NRF52840_DK (see original PR ARMmbed#4088 to see the explanation for the removal of spi async)
@studavekar
Copy link
Contributor

/morph test

@kegilbert
Copy link
Contributor Author

kegilbert commented Jun 9, 2017

NUCLEO_F429ZI-ARM.tests-mbed_drivers-flashiap.FlashIAP - program
NUCLEO_F429ZI-ARM.tests-mbed_hal-flash.Flash - erase sector

Both failed with any compiler (http://mbed-ci-master-2.austin.arm.com:8081/job/test_matrix/475/)

Affected targets:
NUCLEO_F429ZI
UBLOX_EVK_ODIN_W2

Have a second test run kicked off to confirm, but seeing as this is a flash API rework on the above two targets I'm inclined to believe the results for now. Wasn't able to run the test locally at the moment, does anyone more familiar with the original change have any insight?

The tests in question:
https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbed_drivers/flashiap/main.cpp
https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbed_hal/flash/functional_tests/main.cpp

CC @nvlsianpu

@mbed-bot
Copy link

mbed-bot commented Jun 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 511

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2017

@nvlsianpu happy with this rebased patch?

@kegilbert I dont fully understand the above, I cant spot any failures here and those devices are not even touched here.

@nvlsianpu
Copy link
Contributor

looks good

@0xc0170 0xc0170 changed the title [NRF52840]: enabled SdBlockDevice capability - Rebase the rebase NRF52840: enabled SdBlockDevice capability - Rebase the rebase Jun 9, 2017
@0xc0170 0xc0170 changed the title NRF52840: enabled SdBlockDevice capability - Rebase the rebase NRF52840: enabled SdBlockDevice capability Jun 9, 2017
@0xc0170 0xc0170 merged commit e850355 into ARMmbed:master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants