Skip to content

Check for correct library naming in Travis CI #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2017

Conversation

theotherjimmy
Copy link
Contributor

Description

Preventative maintenance for exporters. The build tools are able to handle
incorrectly named libraries, but the exporters can't. This PR adds a CI check
in Travis CI that will prevent incorrectly named libraries from coming in.

Status

ready

Testing

  • Just Travis CI is fine

@theotherjimmy
Copy link
Contributor Author

Dang @0xc0170 That was fast!

@theotherjimmy
Copy link
Contributor Author

@0xc0170 Apparently, I was not done yet

@theotherjimmy
Copy link
Contributor Author

the red x on 3161cf3 was Travis auto-canceling itself.

@theotherjimmy
Copy link
Contributor Author

@sg- Looks like it's passing. LGTM.

@theotherjimmy
Copy link
Contributor Author

Example of what the error will look like:

$ find -name "*.a" -and -not -name "lib*" | tee BUILD/badlibs | sed -e "s/^/Bad library name found: /" && [ ! -s BUILD/badlibs ]
Bad library name found: ./targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_IAR/rom.a
$ echo $?
1

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to fire morph on this since its just touching travis stuff. LGTM.

@bridadan
Copy link
Contributor

@theotherjimmy @0xc0170 Marked as ready for merge just to prevent people from adding morph commands. Feel free to take the tag off if it's not ready yet.

@theotherjimmy
Copy link
Contributor Author

@bridadan I need to add IAR library checking. just a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants