Add new target in mbedtls importer Makefile for mbedtls tests

[mazimkhan]

Description

A new target is added to deploy mbedtls tests along with source code in mbed-os. Separate target is added to prevent changes in current deployment process. For some time it would only be used in staging CI to observer test stability. Also it gives the ability to only import tests for testing mbedtls with mbed-os i.e. only deploy tests for testing purpose.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:
Does not depend but will be used with mbedtls PR Mbed-TLS/mbedtls#930

branch	PR
other_pr_production	link
other_pr_master	link

Todos

• Tests
• Documentation

Deploy notes

• Check out mbedtls inside mbed-os/features/mbedtls/importer/TARGET_IGNORE/
• cd mbed-os/features/mbedtls/importer/TARGET_IGNORE/mbedtls/tests/
• make gen-embedded-tests
• cd ../../../ at importer level
• make deploy-tests
• cd ../../../ at mbed-os level
• Build with mbed-cli
• Run with Greentea

Steps to test or reproduce

See deploy steps.

[mazimkhan]

@sg- @0xc0170 Please review

[mazimkhan]

Ready for merge?
Before we do any further testing please appreciate that this PR does not change any code.

[simonbutcher]

@mazimkhan - you've scripted to copy a file tests/scripts/mbedtls_test.py, but that file doesn't exist in mbed TLS yet. Is this PR a bit premature?

[mazimkhan]

tests/scripts/mbedtls_test.py is being added as part of PR Mbed-TLS/mbedtls#930 hence it depends on that PR.
Since the change is introducing a separated target it does not affect existing import process.

[0xc0170]

@sbutcher-arm Thanks for the review, please let us know if this PR is approved or not.

[theotherjimmy]

@yanesca Could you review?

[adbridge]

bump @yanesca

[theotherjimmy]

@yanesca Could you take a look?

[yanesca]

In general it looks good to me, there are only two minor suggestions I would like to make:

• could we please replace deploy with deploy-tests in the prerequisites of the mbedtls?
• I am probably being overly cautious, but could we please add deploy-tests to the .PHONY targets?

[mazimkhan]

* could we please replace deploy with deploy-tests in the prerequisites of the mbedtls? Please see the PR description. This PR is a stage change in which functionality to generate target tests is added. But existing behaviour is not modified. Generating and importing the tests by default would impact existing CIs. This would be done after on-target testing PR #930 in mbed-tls repo is merged and we decide which mbed-tls tests to run in CI. * I am probably being overly cautious, but could we please add deploy-tests to the .PHONY targets? Thanks I will make this change.

[0xc0170]

• I am probably being overly cautious, but could we please add deploy-tests to the .PHONY targets?
  Thanks I will make this change.

@mazimkhan What is then outstanding in this PR?

[0xc0170]

retest uvisor

[mazimkhan]

I am waiting for @yanesca opinion on

"could we please replace deploy with deploy-tests in the prerequisites of the mbedtls?"

[yanesca]

That makes perfect sense. Looks good to me!

[mazimkhan]

Added deploy-tests to .PHONY target. Ready for merge after CI passes.