Add FlashIAP support for REALTEK_RTL8195AM #4565

Archcady · 2017-06-15T08:31:59Z

Port REALTEK flash APIs to mbed, add FlashIAP support for REALTEK_RTL8195AM

0xc0170 · 2017-06-15T09:01:15Z

@Archcady can you share the test results of flash HAL API and flashIAP ?

Archcady · 2017-06-15T09:13:19Z

Hi @0xc0170, I test it with ARM, GCC_ARM and IAR and here's result with ARM compilers. All testes for all compilers are passed.

mbedgt: test suite report:
+-----------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
| target                | platform_name     | test suite                          | result | elapsed_time (sec) | copy_method |
+-----------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_drivers-flashiap | OK     | 17.41              | shell       |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | OK     | 17.75              | shell       |
+-----------------------+-------------------+-------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 2 OK
mbedgt: test case report:
+-----------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                | platform_name     | test suite                          | test case                     | passed | failed | result | elapsed_time (sec) |
+-----------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - init               | 1      | 0      | OK     | 0.01               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program            | 1      | 0      | OK     | 0.17               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_drivers-flashiap | FlashIAP - program errors     | 1      | 0      | OK     | 0.01               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - buffer alignment test | 1      | 0      | OK     | 0.08               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - clock and cache test  | 1      | 0      | OK     | 0.04               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - erase sector          | 1      | 0      | OK     | 0.05               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - init                  | 1      | 0      | OK     | 0.03               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - mapping alignment     | 1      | 0      | OK     | 0.01               |
| REALTEK_RTL8195AM-ARM | REALTEK_RTL8195AM | mbed-os-tests-mbed_hal-flash        | Flash - program page          | 1      | 0      | OK     | 0.11               |
+-----------------------+-------------------+-------------------------------------+-------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 9 OK
mbedgt: completed in 36.09 sec

0xc0170 · 2017-06-20T10:55:23Z

/morph test

mbed-bot · 2017-06-20T13:53:43Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 593

Test failed!

studavekar · 2017-06-21T18:58:45Z

/morph test

mbed-bot · 2017-06-21T23:30:27Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 603

Test failed!

studavekar · 2017-06-22T02:36:19Z

NRF52_DK-GCC_ARM.tests-mbedmicro-rtos-mbed-basic.tests-mbedmicro-rtos-mbed-basic - Failed

/morph test

mbed-bot · 2017-06-22T04:29:17Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 607

All builds and test passed!

adbridge

Can you please double check the code for mbed coding standards , plus some minor other comments

adbridge · 2017-06-23T10:56:44Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_api.c

-    flash_turnon();
+    //obj->flash_size = FLASH_SIZE;
+    //obj->sector_size = FLASH_SECTOR_SIZE;
+    //obj->page_size = FLASH_PAGE_SIZE;



Why is this code commented out ?

adbridge · 2017-06-23T11:03:55Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_api.c

 {
-    u8 Status = 0;
+    if (address < FLASH_START || address >= FLASH_END)
+        return (uint32_t)-1;


Is this value being returned as an error value ? If this is the case, would an explicit sector size of 0 not be better in this case ?

adbridge · 2017-06-23T11:07:15Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_ext.c

+{
+    if (!SpicFlashInitRtl8195A(SpicOneBitMode)){
+
+        DBG_8195A("SPI Init Fail!!!!!!\n");


Is this debug code meant to be left in ?

adbridge · 2017-06-23T11:09:08Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_ext.c

+    if(flashtype == FLASH_MICRON){
+        SpicWaitOperationDoneRtl8195A(flashobj.SpicInitPara);
+    } else
+    {


should this { be on the else line ?

adbridge · 2017-06-23T11:10:33Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_ext.c

+            *ptr = *pbuf;
+            pbuf++;
+        ptr++;
+        }


Looks like your formatting has gone a bit funny here ?

adbridge · 2017-06-23T11:11:34Z

targets/TARGET_Realtek/TARGET_AMEBA/flash_ext.c

+int flash_stream_write(flash_t *obj, uint32_t addr, uint32_t len, uint8_t *data){
+    return flash_ext_stream_write(obj, addr, len, data);
+}
+


Above two functions '{' should be on newline

theotherjimmy · 2017-06-26T14:46:13Z

@Archcady could you address @adbridge's review?

Archcady · 2017-06-27T03:39:28Z

Thanks @adbridge @theotherjimmy , I've add a coding style patch for this.

adbridge · 2017-06-27T10:18:03Z

LGTM

adbridge · 2017-06-27T10:21:24Z

/morph test

mbed-bot · 2017-06-28T03:57:48Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 663

Test failed!

0xc0170 · 2017-06-28T07:25:57Z

/morph test

mbed-bot · 2017-06-28T16:05:05Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 673

Test failed!

0xc0170 · 2017-06-29T12:19:21Z

retest uvisor

0xc0170 · 2017-06-29T12:19:42Z

/morph test

mbed-bot · 2017-06-29T16:49:04Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 689

Test failed!

0xc0170 · 2017-06-30T09:30:58Z

retest uvisor

adbridge · 2017-06-30T16:51:14Z

Morph test failed for
mbedgt: test suite 'tests-mbedmicro-rtos-mbed-basic' ................................................. FAIL in 26.45 sec
IAR only

theotherjimmy · 2017-06-30T18:56:50Z

/morph test

studavekar · 2017-07-02T04:14:26Z

/morph test

mbed-bot · 2017-07-02T06:46:17Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 716

All builds and test passed!

Add FlashIAP support for REALTEK_RTL8195AM

0de89c7

0xc0170 added the needs: review label Jun 15, 2017

sg- added needs: CI release-version: 5.5.2 and removed needs: review labels Jun 15, 2017

0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2017

adbridge self-requested a review June 23, 2017 11:13

adbridge added needs: work and removed ready for merge labels Jun 23, 2017

adbridge requested changes Jun 23, 2017

View reviewed changes

Coding style fix

f7b2edc

adbridge closed this Jun 27, 2017

adbridge reopened this Jun 27, 2017

sg- removed the needs: work label Jun 27, 2017

adbridge approved these changes Jun 27, 2017

View reviewed changes

adbridge added the needs: CI label Jun 27, 2017

0xc0170 approved these changes Jul 3, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Jul 3, 2017

adbridge merged commit c826e2f into ARMmbed:master Jul 3, 2017

sg- removed the ready for merge label Jul 3, 2017

Archcady deleted the flash branch July 10, 2017 05:46

Add FlashIAP support for REALTEK_RTL8195AM #4565

Add FlashIAP support for REALTEK_RTL8195AM #4565

Uh oh!

Conversation

Archcady commented Jun 15, 2017

Uh oh!

0xc0170 commented Jun 15, 2017

Uh oh!

Archcady commented Jun 15, 2017

Uh oh!

0xc0170 commented Jun 20, 2017

Uh oh!

mbed-bot commented Jun 20, 2017

Output

Uh oh!

studavekar commented Jun 21, 2017

Uh oh!

mbed-bot commented Jun 21, 2017

Output

Uh oh!

studavekar commented Jun 22, 2017

Uh oh!

mbed-bot commented Jun 22, 2017

Output

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Jun 26, 2017

Uh oh!

Archcady commented Jun 27, 2017

Uh oh!

adbridge commented Jun 27, 2017

Uh oh!

adbridge commented Jun 27, 2017

Uh oh!

mbed-bot commented Jun 28, 2017

Output

Uh oh!

0xc0170 commented Jun 28, 2017

Uh oh!

mbed-bot commented Jun 28, 2017

Output

Uh oh!

0xc0170 commented Jun 29, 2017

Uh oh!

0xc0170 commented Jun 29, 2017

Uh oh!

mbed-bot commented Jun 29, 2017

Output

Uh oh!

0xc0170 commented Jun 30, 2017

Uh oh!

adbridge commented Jun 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Jun 30, 2017

Uh oh!

studavekar commented Jul 2, 2017

Uh oh!

mbed-bot commented Jul 2, 2017

Output

Uh oh!

Uh oh!

adbridge commented Jun 30, 2017 •

edited

Loading