Skip to content

Fix mbed2 failures #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2017
Merged

Fix mbed2 failures #4566

merged 3 commits into from
Jun 15, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jun 15, 2017

Fixes for mbed 2 , contains 3 fixes, mainly due to new recent changes, this were revealed.

cc @adbridge @sg-

0xc0170 added 2 commits June 15, 2017 12:09
This fixes an issue as Timer.h is mbed file, thus if this file gets included first,
causes failures.
@adbridge
Copy link
Contributor

/morph test

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 15, 2017

The highlight of these fixes is cmsis a9 header file that we are bringing back for backward compability + its dependencies. Only for cortex-a, as this is not part of the cmsis5 yet.

Tested with RZ_A1H

cmsis 5 does not include it but as mbed 2 requires this, we will bring this file
back. This brings back few other dependencies, that we add only for cortex-a.

Once cortex-a gets cmsis5 and rtx2 support it will be updated.
@adbridge
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 557

Build failed!

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 558

All builds and test passed!

@adbridge adbridge self-requested a review June 15, 2017 13:53
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge adbridge merged commit a6828bb into ARMmbed:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants