DISCO_L072CZ_LRWAN1: Add support of USB Device #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
requested changes
Jun 16, 2017
| /* hardcoded size of FIFO according definition*/ | ||
| HAL_PCDEx_PMAConfig(&hpcd , 0x00 , PCD_SNG_BUF, 0x30); | ||
| HAL_PCDEx_PMAConfig(&hpcd , 0x80 , PCD_SNG_BUF, 0x70); | ||
| #if 1 |
There was a problem hiding this comment.
should this completely disappear (just the code that is now active) or reworked?
There was a problem hiding this comment.
You're right. I'll remove the unactive code.
|
@0xc0170 Could you re-review? |
0xc0170
approved these changes
Jun 20, 2017
|
Can you please resolve conflicts? |
bcostm
force-pushed
the
add_usb_disco_l072cz
branch
from
7fc1fee to
cc47104
Compare
|
Rebased and solved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enable the USB Device on this platform. Clock setting has been updated to enable the HSI48 clock of the device.
Status
READY
USB_1 and USB_4 tests are OK.
Migrations
NO
Testing