Add bootloader support for the UBLOX_C030 platforms. #4590
Conversation
|
@RobMeades is this required alongside #4337 ? They won't both make it into 5.5.1... but #4337 may do ? |
|
Seen the build errors for other ST platforms, seems to be a collision of changes, fixing... |
RobMeades
force-pushed
the
c030_bootloader
branch
2 times, most recently
from
306ff6f to
91be7f0
Compare
|
|
||
| ER_IROM1 0x08000000 0x100000 { ; load address = execution address | ||
| #if !defined(MBED_APP_START) |
There was a problem hiding this comment.
hi - just be aware that those lines seem to have side effects - see here #3958
There was a problem hiding this comment.
Ooo, well spotted, the EmBitz exporter is not something I know anything about and I guess it is not tested by the automation system here. @0xc0170 : is this something I need to be concerned about?
There was a problem hiding this comment.
probably not blocking, but when a solution is found to #3958, let's make sure to report it here as well - either you or us ...
| /*Heap 1/2 of ram and ISR stack 4 kbytes*/ | ||
| define symbol __ICFEDIT_size_cstack__ = 0x1000; | ||
| /*Heap 1/2 of ram and stack 1/8*/ | ||
| define symbol __ICFEDIT_size_cstack__ = 0x6000; |
There was a problem hiding this comment.
why are you increasing cstack to 0x6000?
There was a problem hiding this comment.
Oops, well spotted, that was a hangover from a previous version of this PR; we had reduced the IAR stack size afterwards, now corrected/re-based/re-pushed.
RobMeades
force-pushed
the
c030_bootloader
branch
from
91be7f0 to
a78d9eb
Compare
|
Test results (with this latest rebase): |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
RobMeades
force-pushed
the
c030_bootloader
branch
from
a78d9eb to
7500811
Compare
|
Merged with Jerome's changes to |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
RobMeades
force-pushed
the
c030_bootloader
branch
from
7500811 to
b70967c
Compare
|
...and again: |
Another confict, very last rebase? we will retrigger CI |
RobMeades
force-pushed
the
c030_bootloader
branch
from
b70967c to
1394a26
Compare
|
Done. |
| @@ -1465,10 +1465,11 @@ | |||
| } | |||
| }, | |||
| "macros_add": ["RTC_LSI=1", "HSE_VALUE=12000000", "GNSSBAUD=9600"], | |||
| "device_has_add": ["ANALOGOUT", "TRNG"], | |||
| "device_has_add": ["ANALOGOUT", "SERIAL_FC", "TRNG", "FLASH"], | |||
There was a problem hiding this comment.
@RobMeades Why did "SERIAL_FC" get added here?
There was a problem hiding this comment.
@jeromecoutant's change to all the STM32F4 platforms, which I had to rebase against, dropped it, so I added it back in again.
There was a problem hiding this comment.
I can put that change in another PR if you prefer but I really don't want to wait as we definitely need flow control on the serial ports.
There was a problem hiding this comment.
Cool. Thanks for responding.
RobMeades
force-pushed
the
c030_bootloader
branch
from
1394a26 to
1c7a7bc
Compare
|
Darn, missed out on the last re-base, now fixed, rebased and retested: |
|
retest uvisor |
|
/morph test |
|
@mazimkhan can you check the uvisor CI status here? I restarted it 15mins ago, still waiting. |
|
Don't know what happened. I have restarted the CI. Lets see if it fails now. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@mazimkhan Still not going through, what can we do? |
|
This PR has passed in CI http://e108747.cambridge.arm.com:8080/job/mbed-os/job/mbed-os-pr-uvisor-test-pipeline/3805/ |
|
@mazimkhan We have access control setup so that we cannot merge without your CI passing. Is there a way we can get it reporting for this PR? |
|
We have tried by rerunning the CI but that didn't help. I will try contacting GitHub support. |
|
@RobMeades It might be faster to send a new PR that will reference this. To restart that failing report test. What do you think? |
|
Yup, happy to do that. So that I don't just hit the same issue, do I simply need to submit a new PR from my same branch or should I re-create my branch also and then do a PR from there? |
Yes, this one should do, just a new PR |
|
Closing this PR and opening a new one that references it in order to work around a CI infrastructure issue. |
Description
Add bootloader support for the UBLOX_C030 platforms. Tested with GCC, ARM and IAR toolchains.