bd: Fix missing init in MBRBlockDevice #4607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Jun 22, 2017
|
We need this on a patch release as well (5.5.x). |
theotherjimmy
approved these changes
Jun 26, 2017
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
theotherjimmy
added
ready for merge
release-version: 5.5.2
and removed
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like an init call was missing to the MBRBlockDevice's child block device. This went unnoticed during testing since not all block devices need an init call to function.
I also added an asert on init to the Heap block device, which will at least find these issues if we run filesystem tests.
related issue #4526
cc @netanelgonen, @theotherjimmy