-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: Fix the CAN initializing to the wrong frequency #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y at startup regardless of the value set in the constructor. Issue ARMmbed#3863
This issue has caused so much trouble to me, many thanks for finding this out and fixing it ! |
cc @adustm |
@bperry730 Thanks for the PR. Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful. To match this format, please change the subject line to imperative mood and limit it to 50 characters. We recommend you use "Fix the CAN initializing to the wrong frequency" as the subject line and include the rest of the description in the body. (We use the subject lines of merged PRs in our release notes.) Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, sorry for that ! Thank you for the fix
@bperry730 Can you please sign https://developer.mbed.org/contributor_agreement/ ? |
Hi sorry. I was on vacation in the wilderness away from wifi and email notifications. @AnotherButler thank you for the pointer on commit messages. I will follow the standard in all future commits. @0xc0170 I have signed the agreement. My mbed username is perr1940. Thanks. |
@bperry730 Confirmed that perr1940 has signed the agreement. |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
…y at startup regardless of the value set in the constructor. Issue #3863
Description
Fixing the issue described in #3863
Status
READY
Migrations
NO