Skip to content

STM32: Fix the CAN initializing to the wrong frequency #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

bperry730
Copy link

…y at startup regardless of the value set in the constructor. Issue #3863

Description

Fixing the issue described in #3863

Status

READY

Migrations

NO

…y at startup regardless of the value set in the constructor. Issue ARMmbed#3863
@Nodraak
Copy link
Contributor

Nodraak commented Jun 29, 2017

This issue has caused so much trouble to me, many thanks for finding this out and fixing it !

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 29, 2017

cc @adustm

@AnotherButler
Copy link
Contributor

@bperry730 Thanks for the PR.

Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful.

To match this format, please change the subject line to imperative mood and limit it to 50 characters. We recommend you use "Fix the CAN initializing to the wrong frequency" as the subject line and include the rest of the description in the body. (We use the subject lines of merged PRs in our release notes.)

Thanks for your contribution.

Copy link
Member

@adustm adustm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, sorry for that ! Thank you for the fix

@0xc0170 0xc0170 changed the title Fixing the problem where the CAN is initialized to the wrong frequenc… STM32: Fix the CAN initializing to the wrong frequency Jul 4, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2017

@bperry730
Copy link
Author

Hi sorry. I was on vacation in the wilderness away from wifi and email notifications. @AnotherButler thank you for the pointer on commit messages. I will follow the standard in all future commits. @0xc0170 I have signed the agreement. My mbed username is perr1940.

Thanks.

@theotherjimmy
Copy link
Contributor

@bperry730 Confirmed that perr1940 has signed the agreement.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 758

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 806

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants