Fix LED4 for UBLOX_EVK_NINA_B1 #4674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass. If set to NC the test will assert.
|
@andreaslarssonublox Thanks for the PR. Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful. To match this format, please limit your subject line to 50 characters or fewer. We recommend changing it to "Fix LED4 for UBLOX_EVK_NINA_B1" and including the rest of the information in the description. Thanks for your contributions. |
theotherjimmy
approved these changes
Jun 30, 2017
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
andreaslarssonublox
changed the title
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set LED4 the same as LED3 to get tests-mbedmicro-rtos-mbed-timer to pass for UBLOX_EVK_NINA_B1
This is part of getting the target pass mbed Enabled tests.
If not fixed the test will fail with:
[1498813581.77][CONN][RXD] mbed assertation failed: obj->pin != (PinName)NC, file: C:\git\ARMmbed\mCMSIS-RTOS error: User Timer Callback Queue overflow (status: 0x3, task ID: 0x0, timer ID: 0x200053EC)
Status
READY
Migrations
NO
Related PRs
None
Todos
None
Deploy notes
N/A
Steps to test or reproduce
N/A