Test: RTOS: Semaphore: Rework tests #4682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
c1728p9
reviewed
Jul 10, 2017
|
|
||
| res = t.start(callback(single_thread, &data)); | ||
| TEST_ASSERT_EQUAL(osOK, res); | ||
| Thread::yield(); |
There was a problem hiding this comment.
you might consider using wait instead of yield here to make this test more deterministic. Depending when in the tick you yield the new thread still might not have enough time to call semaphore wait. Also, if the priority of main is below the priority of the new thread, then the yield won't help.
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
|
/morph test |
|
retest uvisor |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Jul 12, 2017
|
@0xc0170 ping |
0xc0170
approved these changes
Jul 17, 2017
|
@c1728p9 happy with the update? |
c1728p9
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more unit style tests for Semaphore class and rework existing test.
Status
READY
CC: @0xc0170