Skip to content

Max32630 UART: Fix IRQ dispatching and CTS/RTS line configuration #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2017
Merged

Max32630 UART: Fix IRQ dispatching and CTS/RTS line configuration #4696

merged 4 commits into from
Jul 24, 2017

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 3, 2017

Description

This PR fixes three bugs in the MAX32630 uart implementation:

  • The IRQs were not dispatched because the object requesting the IRQ to be set was not registered.
  • The UART IRQs flags were not clear
  • The CTS/RTS line configuration was incorrect.

Status

READY

Migrations

NO

@pan-
Copy link
Member Author

pan- commented Jul 3, 2017

@jessexm Could you review this PR ?

@pan- pan- mentioned this pull request Jul 3, 2017
Merged
@theotherjimmy
Copy link
Contributor

@jessexm Could you review this PR?

jessexm
jessexm reviewed Jul 11, 2017
View reviewed changes
Copy link
Contributor

@jessexm jessexm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jessexm
jessexm reviewed Jul 11, 2017
View reviewed changes
Copy link
Contributor

@jessexm jessexm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

jessexm
jessexm suggested changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@jessexm jessexm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed line 122 should reference IOMAN_MAP_B instead of IOMAN_MAP_A.

@pan-
Copy link
Member Author

pan- commented Jul 11, 2017

@jessexm Should be fixed, could you review the changes ?

jessexm
jessexm reviewed Jul 12, 2017
View reviewed changes
Copy link
Contributor

@jessexm jessexm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 809

Example Build failed!

@studavekar
Copy link
Contributor

/morph test

1 similar comment
@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 829

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 742d98a into ARMmbed:master Jul 24, 2017
@pan- pan- deleted the max32630_fix_uart branch November 14, 2018 10:50
@pan- pan- restored the max32630_fix_uart branch November 14, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessexm jessexm jessexm requested changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.5.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pan- @theotherjimmy @0xc0170 @mbed-bot @studavekar @jessexm