Skip to content

Enable greentea testing on CM3DS_MPS2 target #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Enable greentea testing on CM3DS_MPS2 target #4708

merged 1 commit into from
Jul 17, 2017

Conversation

matetothpal
Copy link
Contributor

@matetothpal matetothpal commented Jul 5, 2017

Set copy_method and reset_method in targets.json which is needed for
htrun.

Description

Enable greentea testing on CM3DS_MPS2 target.
Set copy_method and reset_method in targets.json which is needed for htrun.

Status

READY/IN DEVELOPMENT/HOLD

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

Support reset and flash for ARM MPS2 board.: ARMmbed/htrun#160

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this shouldn't require morph testing

@AnotherButler
Copy link
Contributor

@mattot01 Thanks for the PR.

Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. We find the commit.template feature particularly helpful.

To match this format, please delete the period at the end of your subject line. (We use merged PRs in our release notes.) Thanks for your contribution.

Set copy_method and reset_method in targets.json which is needed for
htrun.
@matetothpal
Copy link
Contributor Author

@AnotherButler Thank you for the suggestions, I updated the commit message.

@matetothpal matetothpal changed the title Enable greentea testing on CM3DS_MPS2 target. Enable greentea testing on CM3DS_MPS2 target Jul 6, 2017
@bridadan
Copy link
Contributor

bridadan commented Jul 6, 2017

@0xc0170 I believe this should be ok without further testing. Nothing that morph runs will extend the coverage in this case.

@theotherjimmy
Copy link
Contributor

@bridadan What do these keys do? How does htrun pick them up?

@bridadan
Copy link
Contributor

bridadan commented Jul 10, 2017

Greentea will do its best to find the targets.json file to find out information about the targets. It can then see if it has to do anything target specific to run tests on it (change its flashing strategy, change how long it waits for flashing, etc). This kind of target specific information is generally discouraged, however in this case there wasn't much choice since the target was already produced.

In this case, Greentea has to change how it flashes the binary and how it resets the device (since it doesn't support reset via the serial break).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2017

@mattot01 Is there any other way to do this? This does not look right, to have these 2 in targets.json file. As @bridadan highlighted above, there's not much to do, is that true?

@bridadan
Copy link
Contributor

@0xc0170 This is the correct way to do this for this platform. It doesn't contain a standard mbed interface so we have to modify the test tools behavior.

@theotherjimmy
Copy link
Contributor

theotherjimmy commented Jul 17, 2017

@bridadan I still don't like adding htrun specific info to targets.json. That being said, I'm not going to block it for that reason.

@bridadan
Copy link
Contributor

@theotherjimmy agreed, there's just literally no other place to put it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants