Expose SystemCoreClock via cmsis.h to support new CMSIS/RTX #4714
Conversation
|
Think it's better if @RobMeades reviews it. |
|
/morph test |
|
Looks good to me :) |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Failure not related to this PR /morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputExample Build failed! |
|
Failure not related to this PR /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
| @@ -35,6 +35,7 @@ | |||
| #include "diag.h" | |||
| //#include "hal_common.h" | |||
| //#include "hal_soc_ps_monitor.h" | |||
There was a problem hiding this comment.
Why do we have commented out header files ?
There was a problem hiding this comment.
@Archcady shall know. this was probably left in place and overlooked until now!
There was a problem hiding this comment.
I think these two lines can be deleted, must have been forgotten.
There was a problem hiding this comment.
Thanks, can you send PR to fix that ? This should not gate this PR
There was a problem hiding this comment.
Please see #4747 , thanks.
| @@ -35,6 +35,7 @@ | |||
| #include "diag.h" | |||
| //#include "hal_common.h" | |||
| //#include "hal_soc_ps_monitor.h" | |||
There was a problem hiding this comment.
@Archcady shall know. this was probably left in place and overlooked until now!
|
Can you please rebase to resolve conflict? |
This change is necessary as updated CMSIS/RTX require the SystemCoreClock symbol.
This change is necessary as updated CMSIS/RTX require the SystemCoreClock symbol.
bulislaw
force-pushed
the
expose_systemcoreclock
branch
from
c83bde0 to
693a3a8
Compare
|
@0xc0170 ping |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
|
I also restarted Travis, if it fails to update the status here, we can close/reopen to retrigger it again |
Description
Most platforms do that already, but while updating CMSIS/RTX I hit issues with these two:
Status
READY
CC @0xc0170