STM32: Remove i2c_read() and i2c_write() redirects to HAL_I2C_IsDeviceReady() #4717
+0
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eReady() Some I2C devices require specific zero length read/write sequences which the HAL_I2C_IsDeviceReady() redirect interferes with. After Removing these redirects, it was confirmed that zero length reads and writes would both still work correctly for detecting presence/absence of an I2C device on a bus.
|
@LMESTM |
|
@monkiineko thx - I'll and start tests, hopefully tomorrow |
|
Travis failure is : |
|
Closing and reopening to re-trigger travis to see if this was just a weird timing error on the machine. |
|
@monkiineko I'm busy with other things, but I asked @jeromecoutant to do the testing - he'll report the results |
|
Yes, I have ran tests this morning for each STM32 family:
|
|
@LMESTM @jeromecoutant |
|
@monkiineko I've also used a logic analyzer and have verified the behavior is as expected, on NUCLEO_F446RE (I2C_IP_VERSION_V1) and NUCLEO_L476RG (I2C_IP_VERSION_V2). So I'll approve the PR. |
LMESTM
approved these changes
Jul 10, 2017
|
/morph test |
0xc0170
approved these changes
Jul 10, 2017
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild Prep failed! |
|
Git checkout timed out /morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
Failure not related /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some I2C devices require specific zero length read/write sequences which
the HAL_I2C_IsDeviceReady() redirect interferes with. After Removing
these redirects, it was confirmed that zero length reads and writes
would both still work correctly for detecting presence/absence of an
I2C device on a bus.
Status
READY
Migrations
NO
Todos
Run I2C CI tests on all STM32 targets to confirm no regressions
Steps to test or reproduce
Build an STM32 based target image with an instantiated I2C bus and use an oscilloscope or I2C bus analyzer to confirm that both an I2C read without data and an I2C write without data can be generated, and the expected results returned, using code such as:
#include <mbed.h>...
I2C testI2c(PA_10, PA_9);printf("Write to 0x54 = %d\r\n", testI2c.write(0x54, 0, 0)); // Non-existent I2C device (expect 1 result)printf("Write to 0xA0 = %d\r\n", testI2c.write(0xA0, 0, 0)); // EEPROM (expect 0 result)printf("Read from 0x54 = %d\r\n", testI2c.read(0x54, 0, 0)); // Non-existent I2C device (expect 1 result)printf("Read from 0xA0 = %d\r\n", testI2c.read(0xA0, 0, 0)); // EEPROM (expect 0 result)