[WIZnet][W7500*] unsupported RTC #4728

khj098765 · 2017-07-10T01:12:24Z

unsupported RTC

PWM3 pin enable

0xc0170 · 2017-07-10T13:54:58Z

Can you please rework the commits (to rebase). The commit could be: Wiznet W7500*: remove RTC support and the second paragraph should state why it is being removed (not working, does not have RTC, or anything that could help explaining this removal. PWM3 pin enable in the second commit is another logical change, not related to RTC? or is it?

khj098765 · 2017-07-10T23:32:32Z

I was told to remove software RTC from Andrew Chong.
So we removed the RTC which was previously operated by PWM3.
We are going to pull request when, the internal RTC driver once it is complete.
PWM3 pin enable is related because it was used as RTC in the past.

targets.json contained a key for some targets, `OUTPUT_EXT`, which I moved to `Target`, the root of all targets. Following on that, the tools now use this extension provided by `OUTPUT_EXT` to determine the file type of the output executable.

The input format is now determined by the OUTPUT_EXT key in targets.json, and defaults to "bin" when not specified. This changes the Teensy3_1 and the NRF51x targets' post bulid hooks. Teensy3_1 just converted to intelhex, so we do nothing instead. NRF51x assumed that it was taking in a bin format file. I made it detect file type by extension.

Signed-off-by: Mahadevan Mahesh <[email protected]>

From opt.h: IP_SOF_BROADCAST_RECV (requires IP_SOF_BROADCAST=1) enable the broadcast filter on recv operations. The IP_SOF_BROADCAST_RECV option does not enable or disable recieving broadcast packets, it only enables a software filter.

The extra space between "--no_wrap_diagnostics" and "-e" is inconsistent with the development and release targets. It bugs people (like me) that have little OCD tics 😉.

…HITELIST.

The current implementation of semihost_disabledebug() hangs when used with mbed interface firwmare revision 21164, the first version which added support for this semihost call. I encountered this hang when running a Release build on my mbed-LPC1768 board as the RTOS attempted to disable the debugger before the idle thread put the CPU to sleep. The 21164 interface firmware expects that R1 points to a valid argument block but the current implementation passes in NULL. The fix was to pass in a dummy block which is ignored by the newer 141212 revision of the firmware and allows the 21164 version to proceeed without halting the CPU until a manual reset. Before this fix semihost_disabledebug() did work with the latest mbed interface firmware revision 141212 but I rarely use this revision of the interface firmware due to the instability issues I have encountered in the past with its CDC and LocalFileSystem functionality. With this proposed fix, the code now works with both the 21164 and 141212 revisions of the mbed interface firmware on the mbed-LPC1768.

SERIAL_TX and SERIAL_RX pins used for debug printf cannot be set as available

…ions needed for Nordic targets.

ticker_insert_event() can crash on KLXX (and probably other platforms) if an event is inserted with a timestamp before the current real time. The problem is easy to trigger: you just need to set up a Ticker object, and then disable interrupts for slightly longer than the Ticker object's interval. It's generally bad practice to disable interrupts for too long, but there are some cases where it's unavoidable, and anyway it would be better for the core library function not to crash. The case where I had an unavoidably long interrupts-off interval was writing flash with the FTFA. The FTFA hardware prohibits flash reads while an FTFA command is in progress, so interrupts must be disabled for the whole duration of each command to ensure that there are no instruction fetches from flash-resident ISRs in the course of the execution. An FTFA "erase sector" command takes a fairly long time (milliseconds), and I have a fairly high frequency Ticker (1ms). The problem and the fix are pretty straightforward. ticker_insert_event() searches the linked list to figure out where to insert the new event, looking for a spot earlier than any event currently queued. If the event is in the past, it'll usually end up at the head of the list. When the routine sees that the new event belongs at the head of the list, it calls data->interface->set_interrupt() to schedule the interrupt for the event, since it's the new soonest event. The KLXX version of us_ticker_set_interrupt() then looks to see if the event is in the past, which we've stipulated that it is, so rather than actually setting the interrupt, it simply calls the handler directly. The first thing the Ticker interrupt handler does is re-schedule itself, so we re-enter ticker_insert_event() at this point. This is where the problem comes in: we didn't finish updating the linked list before we called set_interrupt() and thus before we recursed back into ticker_insert_event(). We set the head of the list to the new event but we didn't set the new event's 'next' pointer. The fix is simply to finish updating the list before we call set_interrupt(), which we can do by moving the obj->next initialization ahead of the head pointer update.

Originally the ethernet ISR would be linked in to all mbed-os based firmware because it was named ENET_IRQHandler() so that it would be automatically placed in the FLASH image's interrupt vector table. This meant that programs which made no use of the lwIP stack still pulled in this ISR. This commit changes the name of the routine so that the ISR isn't automatically placed in the interrupt vector table at link time but is instead dynamically placed in the interrupt vector table at runtime when the lwIP stack is initialized. Now the ethernet ISR is only linked in when it is actually needed. Example arm-none-eabi-size output for a simple LED blinking program showing the before and after size results: text data bss dec hex filename 13208 148 7784 21140 5294 LPC1768/HelloWorld.elf text data bss dec hex filename 12700 148 7468 20316 4f5c LPC1768/HelloWorld.elf

when false thread has empty link config must join the network by commissioning

Internal ADC pin are now out of PinMap_ADC array

1. added call to busReset() to KL25Z HAL; now the USB stack survives if you disconnect the cable, similar to LPC40 2. busReset callback to update terminal_connected in USBCDC 3. new bool USBSerial::connected() to read protected terminal_connected property, useful when you want to check if the terminal is ready from main app

Adding support for new platforms into official USB library

Minor change - List of key modifiers updated to include the logo/GUI/windows key. Also added the options to specify the right hand versions of the keys rather than just the left if for some reason someone wants to do this. Changes are limited to the keyboard header file and are backwards compatible. The new modifier values are in line with the table given on page 56 of this document http://www.usb.org/developers/hidpage/HID1_11.pdf

Fixes #4196. As someone might not be aware that settting default_lib to small has some implications regarding thread safety, therefore we print an error.

…RAM. Allows mesh minimal example to compile with IAR.

Added the ability to specify a branch to update rather than a fork Replaced print commands with the use of a logger Updated the run_cmd functions in line with previous improvements

The function headers have been updated to follow the standard format that should be being used for tools in mbed. This is a one line summary followed by a descriptive block with more detail. Updated the handling of the main function so that the logger becomes global and thus works across all the functions. This has been tested with both the fork and branch options, and for levels INFO and DEBUG.

Modifying the code for mbed ci shield test -> analogin_api.c, W7500x_adc.c, gpio_irq_api.c, W7500x_gpio.c Modifying the code for fix bug -> W7500x_uart.c(register control driver problem), W7500x_uart.h, pinmap.c(pullup, pulldown problem)

- deleted dead code - deleted test code

modified coding style. -> pinmap.c

PWM3 pin enable

0xc0170 · 2017-07-11T12:20:06Z

Thanks for the explanation. Something went wrong with the latest merge, please use rebase to be up to date with master.

khj098765 · 2017-07-12T00:02:12Z

My pull request information : master...Wiznet:master

base fork : ARMmbed/mbed-os
base : master
head fork : WIZnet/mbed-os

Is it wrong?
What should I do select base for rebase?

theotherjimmy · 2017-07-12T03:34:05Z

@khj098765 It looks like you did a git merge after you did your rebase. This can happen if your git pull is set to merge (the default) and you follow the recommendation that git makes after you try to push after your rebase: it tells you to pull and merge first. Please don't pull and merge. We will ask you to rebase again. Instead, You should git push --force. This force push will throw away the old history (from before the rebase) and replace it with the new history (that you created with the rebase). Now you're in a tight spot: you have duplicate commits and a merge commit in the history. I think you might be able to get away with a quick bit of git-foo:

Back up that branch! git checkout -b old-master
Checkout the commit from after the rebase. I'm guessing that's going to be commit 482de93 so: git checkout 482de93
Delete the branch named "master": git branch -D master
Name the commit you're currently on as the new master: git checkout -b master
Force push this new state to the remote (I'm guessing that your fork is named wiznet): git push --force -u wiznet

If that works, we should be able to resume development with the new master branch. Otherwise, you created a backup of the current state with the name "old-master" (supposing you followed my steps) that you can fall back on.

khj098765 · 2017-07-12T04:44:54Z

change pull request... #4745

justinkim added 2 commits July 10, 2017 10:09

unsupported RTC

d04473f

delete rtc_api.c

b7f9224

PWM3 pin enable

0xc0170 added the needs: work label Jul 10, 2017

theotherjimmy and others added 25 commits July 11, 2017 08:43

Issue 3763: Reduce heap allocation in the GCC linker file

5069557

Signed-off-by: Mahadevan Mahesh <[email protected]>

STM32L0: add family in USBEndpoints.h

dccb648

DISCO_L053C8: enable HSI48 clock for USB

a3d307b

DISCO_L053C8: add USBHAL_STM files

9d6a064

DISCO_L053C8: Typo corrections

2e12700

[STM32L0] reduce IAR heap and stack size for small targets

fa3484a

Elide adding regions to profile when empty

f37b546

Removed superfluous space

1c3114e

The extra space between "--no_wrap_diagnostics" and "-e" is inconsistent with the development and release targets. It bugs people (like me) that have little OCD tics 😉.

Fix mbed-cli issue #468. Add LPCTargetCode.lpc_patch to POST_BINARY_W…

de19349

…HITELIST.

NUCLEO_L476RG : minor serial pin update

4ea5fcb

SERIAL_TX and SERIAL_RX pins used for debug printf cannot be set as available

IAR exporter: extended debugger settings template with modifiable opt…

f62eeb2

…ions needed for Nordic targets.

Force events into the future

11aa2b3

Update us_ticker.c

ae8f756

Introducing UBLOX_C030 platform.

0d5fc17

Raise error when mbed_app.json is bad

ad903b7

thread-static-link-config paramter added

80769fc

when false thread has empty link config must join the network by commissioning

Arm powered core removed.

a70cb50

- some refactoring and cleaning

fdb8f9a

config update to the previous commit

b4367bf

jeromecoutant and others added 23 commits July 11, 2017 08:44

NUCLEO_F207ZG: I2C_3 is not available

3b2b742

STM32F2 Internal ADC channels rework

610d90f

Internal ADC pin are now out of PinMap_ADC array

Fix formatting in tools/build_travis.py

89bab62

Fix formatting in targets/targets.json

2f8aff0

Add USB capabilities to NUCLEO-F446RE board

44c38df

Move target files

7dd7692

Maxim USB library update

2c217fa

Adding support for new platforms into official USB library

tests: race test - add not supported for single threaded env

df57a58

Fixes #4196. As someone might not be aware that settting default_lib to small has some implications regarding thread safety, therefore we print an error.

[NCS36510] Reduce default heap size allocated by IAR to 1/4 of total …

37e60db

…RAM. Allows mesh minimal example to compile with IAR.

test - add nanostack to examples.json file

308cf9f

Updated script to add an extra feature and general improvements.

507b3e9

Added the ability to specify a branch to update rather than a fork Replaced print commands with the use of a logger Updated the run_cmd functions in line with previous improvements

Modified coding style of mbed.

b7382ce

- deleted dead code - deleted test code

modified typo

bd839f3

delete dead code. -> gpio_irq_api.c

b134484

modified coding style. -> pinmap.c

add to support gcc & iar

8f21d6d

modify GCC_ARM startup code & mbed_rtx.h syntax error correct.

7434bbd

unsupported RTC

8a62825

delete rtc_api.c

482de93

PWM3 pin enable

Merge branch 'master' of https://github.com/Wiznet/mbed-os

0849b6c

khj098765 mentioned this pull request Jul 12, 2017

WIZnet W7500*: Remove support for RTC #4745

Merged

khj098765 closed this Jul 12, 2017

sg- removed the needs: work label Jul 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIZnet][W7500*] unsupported RTC #4728

[WIZnet][W7500*] unsupported RTC #4728

Uh oh!

khj098765 commented Jul 10, 2017

Uh oh!

0xc0170 commented Jul 10, 2017

Uh oh!

khj098765 commented Jul 10, 2017

Uh oh!

0xc0170 commented Jul 11, 2017

Uh oh!

khj098765 commented Jul 12, 2017

Uh oh!

theotherjimmy commented Jul 12, 2017

Uh oh!

khj098765 commented Jul 12, 2017

Uh oh!

Uh oh!

[WIZnet][W7500*] unsupported RTC #4728

[WIZnet][W7500*] unsupported RTC #4728

Uh oh!

Conversation

khj098765 commented Jul 10, 2017

Uh oh!

0xc0170 commented Jul 10, 2017

Uh oh!

khj098765 commented Jul 10, 2017

Uh oh!

0xc0170 commented Jul 11, 2017

Uh oh!

khj098765 commented Jul 12, 2017

Uh oh!

theotherjimmy commented Jul 12, 2017

Uh oh!

khj098765 commented Jul 12, 2017

Uh oh!

Uh oh!