Skip to content

NRF52832: Extend idle thread stack size to 512 bytes. #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 11, 2017

Description

Fix a crash where the idle thread stack size overflows. This crash
was depending on the compiler and standard library used.

Status

READY

Migrations

NO

Fix a crash where the idle thread stack size overflows. This crash
was depending on the compiler and standard library used.
@pan-
Copy link
Member Author

pan- commented Jul 11, 2017

@0xc0170 Should resolve #4735 . I would like to have this fix included in 5.5.3.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2017

/morph test

Copy link

@marisabele marisabele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works for TARGET_MCU_NRF52832

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 782

All builds and test passed!

@thinkberg
Copy link
Contributor

I am still having this issue on the NRF52832. Increasing it to 768 works so far. I was wondering, why is there no guard like in mbed_rtx_conf.h?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2017

@thinkberg Please create an issue with details how to reproduce the issue.

@thinkberg
Copy link
Contributor

I would like to, but I may have a questions regarding that, like what influences the stack usage of the idle task, so I can try to reproduce without exposing all code.

@pan-
Copy link
Member Author

pan- commented Nov 6, 2017

The compiler, its version and the compilation options are the main cause of idle thread stack size overflows.

Until static analysis is used to determine the maximum depth of the idle thread stack on every build, I'm afraid there is no reliable solution.

@thinkberg
Copy link
Contributor

Then it would make sense to have a guard and be able to set the size in the config, because right now I have to patch mbed-os directly.

@pan- pan- deleted the fix_nrf52_idle_stack branch November 14, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants