Skip to content

ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api #4738

merged 1 commit into from
Jul 27, 2017

Conversation

SeppoTakalo
Copy link
Contributor

This PR replaces the #4678 by limiting the scope for files that our team maintains.
I squashed two of @KariHaapalehto commits together and submitted as a new PR.

Description

Fix some compiler warnings from mesh-api

Status

READY

Migrations

NO

@KariHaapalehto
ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api
f3c7e0d 
Warning ARMmbed#1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning

Warning #1-D: last line of file ends without a newline
- New line added at the end of file

Warning ARMmbed#997-D:
function "MeshInterfaceNanostack::initialize(NanostackPhy *)" is hidden
by "ThreadInterface::initialize"  -- virtual function override intended?
- virtual keyword removed from "MeshInterfaceNanostack::initialize"

Warning ARMmbed#1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning
@SeppoTakalo SeppoTakalo mentioned this pull request Jul 11, 2017
Closed
2 tasks
@SeppoTakalo SeppoTakalo requested a review from kjbracey July 11, 2017 13:07
@SeppoTakalo
Copy link
Contributor Author 

java.io.IOException: remote file operation failed: c:\jsbld\ws\mbed-os\mbed-os-pr-uvisor-test-pipeline@8 at hudson.remoting.Channel@719875d1:e104819_builds: java.nio.file.DirectoryNotEmptyException: c:\jsbld\ws\mbed-os\mbed-os-pr-uvisor-test-pipeline@8\autogen\2\mbed-os\targets\TARGET_ublox\TARGET_HI2110\device
	at hudson.FilePath.act(FilePath.java:986)
	at hudson.FilePath.act(FilePath.java:968)
	at hudson.FilePath.deleteRecursive(FilePath.java:1170)
	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:68)
	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:61)

How can I restart the Cam-CI uvisor Build & Test?

@SeppoTakalo
Copy link
Contributor Author

retest uvisor

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 12, 2017

retest uvisor

@theotherjimmy
Copy link
Contributor

@geky Could you review?

geky
geky approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@theotherjimmy
Copy link
Contributor

Thanks!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 24, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 870

Test failed!

@SeppoTakalo
Copy link
Contributor Author

From http://mbed-ci-master-2.austin.arm.com:8081/job/test_matrix/765/target=NCS36510,toolchain=IAR/testReport/junit/NCS36510-IAR/tests-events-timing/tests_events_timing/

Standard Output

[1500923562.47][HTST][INF] host test executor ver. 1.1.9
[1500923562.47][HTST][INF] copy image onto target...
[1500923562.48][COPY][INF] Waiting up to 60 sec for '120000004420312059465238323032203631303297969903' mount point (current is 'I:')...
        1 file(s) copied.
[1500923582.19][HTST][INF] starting host test process...
[1500923642.22][HTST][ERR] Conn process failed to start in 60.000000 sec
[1500923642.22][HTST][INF] {{result;timeout}}

Does not seem to relate to this one..
@0xc0170 Can you restart the test please.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 881

Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2017 •
edited
Loading

Waiting for one fix to resolve a build error, will restart CI once that is done (thus aborted)

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 884

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 26, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 894

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 3f52924 into ARMmbed:master Jul 27, 2017
@SeppoTakalo SeppoTakalo mentioned this pull request Aug 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geky geky geky approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.5.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeppoTakalo @0xc0170 @theotherjimmy @mbed-bot @geky @KariHaapalehto