Add support for the VBLUno52 board #4765

iotmember · 2017-07-17T16:43:49Z

Description

This PR add new target for the VBLUno52 board (VNG Bluetooth Low Energy UNO nRF52832)

The VBLUno52 board
nRF52832 ARM Cortex-M4F processor
Bluetooth Low Energy 5.0
DAPLink interface
UNO pinout
4 power
Pinout :

Status

READY

Migrations

NO

Test results

Pass all test case in mbed test suite

test_result_vbluno52.zip

0xc0170 · 2017-07-18T09:01:05Z

Can you please instead of merging rebase your branch from master? thanks

iotmember · 2017-07-19T16:54:50Z

@0xc0170 Give me more specific about your request? Thank you

theotherjimmy · 2017-07-19T17:00:33Z

@iotvietmember You used the command git merge or git pull (which defaults to the same behavior as git merge) to pull in changes from the latest master and resolve your conflicts. This created a commit with a name starting with "Merge branch" and that indicated to us that you used a merge. Instead of using git merge or git pull we are asking that you use the command git rebase in particular, the command you would probably run is git rebase master.

Looks like you just got it, actually!

iotmember · 2017-07-19T17:03:51Z

@theotherjimmy I have just fixed the problem. Was my action right or wrong?

theotherjimmy · 2017-07-19T17:05:25Z

What matters is that the history looks correct. I think you took a correct action.

iotmember · 2017-07-19T17:07:18Z

@theotherjimmy @0xc0170 Thank you for your support. I hope that this PR will be reviewed soon.

iotmember · 2017-07-21T16:06:41Z

@theotherjimmy I hope that this commit will be reviewed soon. Thank you very much

theotherjimmy

Looking good, but we should get another review on here.

Questions/minor improvements suggested below.

theotherjimmy · 2017-07-21T16:48:34Z

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_VBLUNO52/device.h

+
+
+
+


Why is this file full of white space?

theotherjimmy · 2017-07-21T16:50:41Z

targets/targets.json

+        "supported_form_factors": ["ARDUINO"],
+        "inherits": ["MCU_NRF52"],
+        "macros_add": ["BOARD_PCA10040", "NRF52_PAN_12", "NRF52_PAN_15", "NRF52_PAN_58", "NRF52_PAN_55", "NRF52_PAN_54", "NRF52_PAN_31", "NRF52_PAN_30", "NRF52_PAN_51", "NRF52_PAN_36", "NRF52_PAN_53", "S132", "CONFIG_GPIO_AS_PINRESET", "BLE_STACK_SUPPORT_REQD", "SWI_DISABLE0", "NRF52_PAN_20", "NRF52_PAN_64", "NRF52_PAN_62", "NRF52_PAN_63"],
+        "device_has": ["ANALOGIN", "ERROR_PATTERN", "I2C", "I2C_ASYNCH", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SLEEP", "SPI", "SPI_ASYNCH", "SPISLAVE"],


Could you not set ERROR_PATTERN? It's not really a piece of hardware after all...

iotmember · 2017-07-21T17:15:56Z

@theotherjimmy I have just fixed the problem in "device.h". I think that I should declare ERROR_PATTERN in "targets.json" for the VBLUno52 board which use Nordic nRF52832 chip, same as NRF52_DK board.
Thank you for your support.

theotherjimmy · 2017-07-21T17:17:09Z

@iotvietmember I don't understand what you're trying to say. Could you explain?

iotmember · 2017-07-21T17:18:38Z

@theotherjimmy I have just fixed the problem in "device.h". I think that I should declare ERROR_PATTERN in "targets.json" for the VBLUno52 board which use Nordic nRF52832 chip, same as NRF52_DK board.
Thank you for your support.

theotherjimmy · 2017-07-21T17:21:03Z

Hmmm... @iotvietmember I would rather the Nordic boards, or any boards, not declare "ERROR_PATTERN" in targets.json. It certainly won't affect support. It only affects the led behavior of the function mbed_die.

iotmember · 2017-07-21T17:26:41Z

@theotherjimmy In your opinion, What is file name which I need to declare ERROR_PATTERN in it?

theotherjimmy · 2017-07-21T17:28:06Z

@iotvietmember leave it in targets.json. I'll submit a PR to remove all of the ERROR_* things next week.

iotmember · 2017-07-21T17:33:57Z

@theotherjimmy I have just fixed the problem about ERROR_PATTERN for the VBLUno52 and VBLUno51 board in targets.json.

theotherjimmy · 2017-07-21T18:22:15Z

@iotvietmember ~~Now your commit modifies VBLUno51 as well. Could you add that to the commit message or break up the commit?~~ You added it to the commit message! My bad.

theotherjimmy

👍

Fix ERROR_PATTERN in VBLUNO52 config Signed-off-by: iotvietmember <[email protected]>

iotmember · 2017-07-22T04:25:59Z

@theotherjimmy I have just fixed the problem. Thanks

0xc0170 · 2017-07-24T10:14:20Z

/morph test

theotherjimmy · 2017-07-24T15:41:09Z

/morph export-build

mbed-bot · 2017-07-25T00:34:17Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 872

Build failed!

mbed-bot · 2017-07-25T04:13:58Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 91

All exports and builds passed!

iotmember · 2017-07-25T04:59:12Z

@theotherjimmy The test results is good. Thank you

0xc0170 · 2017-07-25T14:54:49Z

/morph test

mbed-bot · 2017-07-25T22:21:28Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 885

All builds and test passed!

0xc0170 added the needs: work label Jul 18, 2017

iotmember force-pushed the add_vbluno52 branch from bd9d3eb to 454ef60 Compare July 19, 2017 17:00

theotherjimmy approved these changes Jul 21, 2017

View reviewed changes

iotmember force-pushed the add_vbluno52 branch from 454ef60 to 2bdfb3e Compare July 21, 2017 17:14

iotmember force-pushed the add_vbluno52 branch from 2bdfb3e to 824132d Compare July 21, 2017 17:31

theotherjimmy approved these changes Jul 21, 2017

View reviewed changes

Add support for the VBLUno52 board

bd49f43

Fix ERROR_PATTERN in VBLUNO52 config Signed-off-by: iotvietmember <[email protected]>

iotmember force-pushed the add_vbluno52 branch from 824132d to bd49f43 Compare July 22, 2017 04:24

0xc0170 added needs: CI and removed needs: work labels Jul 24, 2017

theotherjimmy added the scope: new-target label Jul 24, 2017

0xc0170 added ready for merge and removed needs: CI labels Jul 26, 2017

theotherjimmy merged commit 74387f8 into ARMmbed:master Jul 27, 2017

theotherjimmy added release-version: 5.5.4 and removed ready for merge labels Jul 27, 2017

Add support for the VBLUno52 board #4765

Add support for the VBLUno52 board #4765

Uh oh!

Conversation

iotmember commented Jul 17, 2017

Description

Status

Migrations

Test results

Uh oh!

0xc0170 commented Jul 18, 2017

Uh oh!

iotmember commented Jul 19, 2017

Uh oh!

theotherjimmy commented Jul 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iotmember commented Jul 19, 2017

Uh oh!

theotherjimmy commented Jul 19, 2017

Uh oh!

iotmember commented Jul 19, 2017

Uh oh!

iotmember commented Jul 21, 2017

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

theotherjimmy Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

theotherjimmy Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iotmember commented Jul 21, 2017

Uh oh!

theotherjimmy commented Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iotmember commented Jul 21, 2017

Uh oh!

theotherjimmy commented Jul 21, 2017

Uh oh!

iotmember commented Jul 21, 2017

Uh oh!

theotherjimmy commented Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jul 22, 2017

Uh oh!

0xc0170 commented Jul 24, 2017

Uh oh!

theotherjimmy commented Jul 24, 2017

Uh oh!

mbed-bot commented Jul 25, 2017

Result: FAILURE

Output

Uh oh!

mbed-bot commented Jul 25, 2017

Result: SUCCESS

Output

Uh oh!

iotmember commented Jul 25, 2017

Uh oh!

0xc0170 commented Jul 25, 2017

Uh oh!

mbed-bot commented Jul 25, 2017

Result: SUCCESS

Output

Uh oh!

Uh oh!

theotherjimmy commented Jul 19, 2017 •

edited

Loading

iotmember commented Jul 21, 2017 •

edited

Loading

theotherjimmy commented Jul 21, 2017 •

edited

Loading

theotherjimmy commented Jul 21, 2017 •

edited

Loading

theotherjimmy commented Jul 21, 2017 •

edited

Loading