Copy static files only

[johanstokking]

Signed-off-by: Johan Stokking [email protected] (ARM mbed OS developer site username johanstokking)

Description

Closes #4802
Replaces #4803

Status

READY

[theotherjimmy]

This misses the True part of the

if zip_proj

conditional. Could you change that branch to account for the new static_files too?

[theotherjimmy]

That's not really what I meant. It's meaningless to copy files around when the export product is the zip file. I meant something like:

 if zip_proj:
         for resource in resource_dict.values():
             for label, res in resource.features.iteritems():
                 if label not in toolchain.target.features:
                     resource.add(res)
         if isinstance(zip_proj, basestring):
             zip_export(join(export_path, zip_proj), name, resource_dict, files + exporter.static_files,
                        inc_repos)
         else:
             zip_export(zip_proj, name, resource_dict, files + exporter.static_files, inc_repos)

Which would add the static files to the zip

[Nodraak]

Hi!

First of all, thank you for your contribution!

As part of my "improve mbed's Python code quality" quest, I will kindly ask you to rewrite in favour of a more pythonic way: (the trailing coma on line 3 is intentional, and we can use ( instead of [ for imutable tuple instead of mutable list)

self.static_files = (
    join(self.TEMPLATE_DIR, "GettingStarted.html"),
    join(self.TEMPLATE_DIR, ".mbed"),
)

instead of

self.static_files = [join(self.TEMPLATE_DIR, "GettingStarted.html"),
                     join(self.TEMPLATE_DIR, ".mbed")]

Thank you :)

[johanstokking]

@theotherjimmy got it, makes totally sense

@Nodraak these are my first lines of Python, thanks for the education 😉

[theotherjimmy]

@Nodraak

the trailing coma on line 3 is intentional, and we can use ( instead of [ for imutable tuple instead of mutable list

The trailing coma is not required to use ( to create a tuple. However, I prefer your style advice. Just wanted to make sure that @johanstokking got correct information.

[theotherjimmy]

Looks good. Thanks for the fix!

[theotherjimmy]

/morph export-build

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 93

All exports and builds passed!

[theotherjimmy]

Thanks for the fix @johanstokking! It's a big improvement.