-
Notifications
You must be signed in to change notification settings - Fork 3k
Add new target: L-TEK FF1705 #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If this target is based on the XDOT, Why does it inherit from FAMILY_STM32 and not the XDOT target? |
@theotherjimmy good point. I corrected. |
based on XDOT
targets/targets.json
Outdated
"supported_form_factors": ["ARDUINO"], | ||
"inherits": ["XDOT_L151CC"], | ||
"detect_code": ["8080"], | ||
"extra_labels_add": ["L-TEK"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother with this label if there is no code needed for this target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for minimizing it with me.
Thank you! I have one question though. Can I add these lines inside PinNames.h of XDOT target?
|
Possibly yes, if they share both, and most of the file is the same, otherwise use separate header file |
@gorazdko Can you please share any tests results that has been done on this platform? |
We can squash these 3 commits into one to clean the history a bit (or can rebase), let us know. We will trigger CI then |
Sure, you can squash them. Test results: Thanks |
/morph test |
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 132 Exporter Build failed! |
@theotherjimmy This is the second failure, the same one I have seen in another PR for a new target. Please have a look |
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 152 All exports and builds passed! |
based on XDOT
Status: ready