Skip to content

Add new target: L-TEK FF1705 #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2017
Merged

Add new target: L-TEK FF1705 #4973

merged 3 commits into from
Sep 22, 2017

Conversation

gorazdko
Copy link
Contributor

@gorazdko gorazdko commented Aug 24, 2017

based on XDOT

Status: ready

@theotherjimmy theotherjimmy changed the title new target added L-TEK FF1705 Add new target: L-TEK FF1705 Aug 24, 2017
@theotherjimmy
Copy link
Contributor

If this target is based on the XDOT, Why does it inherit from FAMILY_STM32 and not the XDOT target?

@gorazdko
Copy link
Contributor Author

@theotherjimmy good point. I corrected.

"supported_form_factors": ["ARDUINO"],
"inherits": ["XDOT_L151CC"],
"detect_code": ["8080"],
"extra_labels_add": ["L-TEK"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bother with this label if there is no code needed for this target?

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for minimizing it with me.

@gorazdko
Copy link
Contributor Author

Thank you!

I have one question though. Can I add these lines inside PinNames.h of XDOT target?

#ifdef TARGET_FF1705_L151CC
    // Arduino Headers
    D0  = PA_10,
    D1  = PA_9,
    D2  = PA_11,
    D3  = PA_12,
    D10 = PB_12,
    D11 = PB_15,
    D12 = PB_14,
    D13 = PB_13,
    D14 = I2C_SDA,
    D15 = I2C_SCL,
#endif

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2017

Possibly yes, if they share both, and most of the file is the same, otherwise use separate header file

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2017

@gorazdko Can you please share any tests results that has been done on this platform?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2017

We can squash these 3 commits into one to clean the history a bit (or can rebase), let us know. We will trigger CI then

@gorazdko
Copy link
Contributor Author

gorazdko commented Sep 5, 2017

Sure, you can squash them. Test results:
results.txt

Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2017

/morph test

@theotherjimmy
Copy link
Contributor

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Sep 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1221

All builds and test passed!

@mbed-bot
Copy link

mbed-bot commented Sep 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 132

Exporter Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2017

@theotherjimmy This is the second failure, the same one I have seen in another PR for a new target. Please have a look

@theotherjimmy
Copy link
Contributor

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 152

All exports and builds passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants