disable -f option for assembly files for IAR #4977
Conversation
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
/morph mbed2-release |
|
/morph test |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
/morph mbed2-release |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
|
|
@theotherjimmy can you please review. |
There was a problem hiding this comment.
Not sure this would matter but we use .txt extension with -f and the user manual says the extension should be .xcl
From #4879
06:22:52 [DEBUG] Compile: C:\Program Files (x86)\IAR Systems\Embedded Workbench 7.5\arm\bin\iasmarm ... -f .\BUILD\NUCLEO_F767ZI\IAR\.includes_5a547c6d82611f64c4e2715b8a0e2ca1.txt
and
By default, extended command line files have the extension xcl, and can be specified
using the -f command line option. For example, to read the command line options from
extend.xcl, enter:
iasmarm -f extend.xcl
Assuming this doesn't make a difference, what is in the file included by -f that we'd loose?
We provide the include directories to the preprocessor via the |
|
Oh, FYI, |
|
@sg- I tried changing the extension to .xcl with the test application that was sent to IAR and iasmarm still crashes. After this PR goes in and IAR is working with CI, another pr should probably be made to turn off |
|
As per the development guide -f is C/C++ Compiler option only and should be set in C/C++ Extra options |
|
@deepikabhavnani Good point. That might explain why it's not working so well. 😆 |
|
If the changes looks good we should merge it to unblock CI. |
|
Agreed. Just a sec. |
|
@studavekar Unblocking CI! |
This fixes IAR build failure #4879 .