RTL8195AM - Respect Toolchains paths in post bulid script. #5042

tung7970 · 2017-09-07T03:07:38Z

Description

Respect [GCC_ARM|ARM|IAR]_PATH from mbed_settings.py, for users might set path through that file instead of system path.

Status

READY

Migrations

NO

Related PRs

List related PRs against other branches:

Todos

NONE

Deploy notes

NONE

Steps to test or reproduce

NONE

bulislaw · 2017-09-07T08:51:12Z

@theotherjimmy

theotherjimmy · 2017-09-07T14:01:04Z

Does this also work when the compilers are found in the PATH?

theotherjimmy · 2017-09-07T14:01:36Z

FYI, the Cam-CI job was aborted (10 times!) so that's why it's red.

tung7970 · 2017-09-07T14:21:12Z

If a compiler path is set in mbed_settings.py, the binary hook script will use that. If it is empty, it will fallback to use compiler found in system path.

tung7970 · 2017-09-07T14:28:35Z

It's a bit confusing on the compiler paths. Some examples in mbed_settings.py point to the installation directory, some points to the binary directory.

The post processing script for RTL8195AM expects binary directory for all compilers. Maybe that's why Cam-CI is failing ?

#ARM_PATH = "C:/Program Files/ARM"
#IAR_PATH = "C:/Program Files (x86)/IAR Systems/Embedded Workbench 7.0/arm"

#GCC_CR_PATH = "C:/code_red/RedSuite_4.2.0_349/redsuite/Tools/bin"
#GOANNA_PATH = "c:/Program Files (x86)/RedLizards/Goanna Central 3.2.3/bin"

theotherjimmy · 2017-09-07T14:29:11Z

Thanks for the clarification @tung7970. ~~I think this change is a clear improvement, and it sounds like there are no downsides. I'm marking this needs: CI now.~~ See my below comments. I'm actually marking this needs: work until they're implemented.

theotherjimmy · 2017-09-07T14:30:03Z

@tung7970 You're right. There's another way to get the toolchain paths that will be more compatible... Just a moment. I'll give you a link.

theotherjimmy · 2017-09-07T14:31:55Z

https://github.com/ARMmbed/mbed-os/blob/master/tools/toolchains/__init__.py#L1538-L1543 is updated by the build scripts to include the paths. The globals are left alone. If you want to support env var specification of toolchain paths, you should use the TOOLCHAIN_PATHS global instead of the settings.

theotherjimmy · 2017-09-07T14:33:18Z

tools/targets/REALTEK_RTL8195AM.py

@@ -8,6 +8,9 @@
 import hashlib
 import shutil

+from tools.settings import GCC_ARM_PATH
+from tools.settings import ARM_PATH
+from tools.settings import IAR_PATH


Could you use

from tools.toolchains import TOOLCHAIN_PATHS

instead?

tung7970 · 2017-09-07T15:01:20Z

Done. Let me know if this is OK. Thanks.

theotherjimmy · 2017-09-07T15:30:42Z

tools/targets/REALTEK_RTL8195AM.py

@@ -153,7 +154,7 @@ def parse_load_segment_armcc(image_elf):
    (offset, addr, size) = (0, 0, 0)
    segment_list = []
    in_segment = False
-    cmd = 'fromelf --text -v --only=none ' + image_elf
+    cmd = os.path.join(TOOLCHAIN_PATHS['ARM'], 'bin', 'fromelf --text -v --only=none ') + image_elf


What if they compile for uARM? Do you think that you need to handle that case? does your target support uARM?

uARM is not supported at this moment. Will need to check if it can be added easily.

theotherjimmy · 2017-09-07T15:31:51Z

Thanks for getting back to me so quickly @tung7970. It looks better, and should pass Cam-CI.

FYI, we are focusing CI on the 5.6.0 and 5.5.7 releases right now, so this PR may have to wait until we get through more of those PRs.

theotherjimmy · 2017-09-07T15:32:40Z

I also changed the title to match the contents of this PR.

0xc0170 · 2017-09-27T13:33:45Z

/morph test

studavekar · 2017-09-28T03:14:27Z

/morph test

mbed-bot · 2017-09-28T06:02:13Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1414

Build failed!

theotherjimmy · 2017-10-02T15:22:37Z

00:41:52 Traceback (most recent call last):
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\test_api.py", line 2100, in build_test_worker
00:41:52     bin_file = build_project(*args, **kwargs)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\build_api.py", line 552, in build_project
00:41:52     res, _ = toolchain.link_program(resources, build_path, name)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\toolchains\__init__.py", line 1145, in link_program
00:41:52     self.binary(r, elf, bin)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\hooks.py", line 54, in wrapper
00:41:52     post_res = tooldesc["post"](t_self, *args, **kwargs)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\targets\__init__.py", line 536, in binary_hook
00:41:52     rtl8195a_elf2bin(t_self, elf, binf)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\targets\REALTEK_RTL8195AM.py", line 261, in rtl8195a_elf2bin
00:41:52     segment = parse_load_segment(t_self.name, image_elf)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\targets\REALTEK_RTL8195AM.py", line 226, in parse_load_segment
00:41:52     return parse_load_segment_gcc(image_elf)
00:41:52   File "C:\mj\workspace\bm_wrap\1516\mbed-os\tools\targets\REALTEK_RTL8195AM.py", line 127, in parse_load_segment_gcc
00:41:52     for line in subprocess.check_output(cmd, shell=True, universal_newlines=True).split("\n"):
00:41:52   File "c:\python27\Lib\subprocess.py", line 574, in check_output
00:41:52     raise CalledProcessError(retcode, cmd, output=output)
00:41:52 CalledProcessError: Command 'C:/Program Files (x86)/GNU Tools ARM Embedded/gcc-arm-none-eabi-6-2017-q1-update-win32/bin/arm-none-eabi-readelf -l C:\mj\workspace\bm_wrap\1516\mbed-os\BUILD\tests\REALTEK_RTL8195AM\GCC_ARM\.\TESTS\mbedmicro-rtos-mbed\mutex\mutex.elf' returned non-zero exit status 1

This looks related to your PR.

tung7970 · 2017-10-03T04:13:28Z

Not a big fan of windows, but this is weird. A simple readelf command occasionally fails. Let me check if I can reproduce it locally.

0xc0170 · 2017-10-09T12:54:30Z

@tung7970 Any update?

tung7970 · 2017-10-09T14:27:46Z

@0xc0170 Can't reproduce this issue using local greentea, but I guess the space in windows path might have something to do with this.

Anyway, I have slightly tweaked the way command is concatenated. Please check if the modified version does any difference.

Also rebased to the latest master.

mbed-ci · 2017-10-09T15:32:04Z

Build : SUCCESS

Build number : 11
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5042/

Use TOOLCHAIN_PATHS to locate toolchain binaries for users might set compiler paths, through mbed_settings.py, env vars, or system path. Signed-off-by: Tony Wu <[email protected]>

mbed-ci · 2017-10-09T16:17:36Z

Build : FAILURE

Build number : 13
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5042/

0xc0170 · 2017-10-10T09:02:07Z

/morph build

0xc0170 · 2017-10-19T11:22:04Z

/morph build

mbed-ci · 2017-10-19T11:43:49Z

Build : SUCCESS

Build number : 258
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5042/

Skipping test trigger, missing label 'NEED CI'

studavekar · 2017-10-19T23:59:09Z

/morph test

mbed-ci · 2017-10-20T01:54:41Z

Test : SUCCESS

Build number : 130
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5042/130

tung7970 changed the title ~~rtl8195am - Respect [GCC_ARM|ARM |IAR]_PATH from mbed_settings.py~~ RTL8195AM - Respect [GCC_ARM|ARM |IAR]_PATH from mbed_settings.py Sep 7, 2017

0xc0170 added the needs: review label Sep 7, 2017

theotherjimmy approved these changes Sep 7, 2017

View reviewed changes

theotherjimmy added needs: work and removed needs: review labels Sep 7, 2017

theotherjimmy suggested changes Sep 7, 2017

View reviewed changes

tung7970 force-pushed the fix-tools branch from 445963c to 4a05375 Compare September 7, 2017 15:00

theotherjimmy reviewed Sep 7, 2017

View reviewed changes

theotherjimmy approved these changes Sep 7, 2017

View reviewed changes

theotherjimmy changed the title ~~RTL8195AM - Respect [GCC_ARM|ARM |IAR]_PATH from mbed_settings.py~~ RTL8195AM - Respect Toolchains paths in post bulid script. Sep 7, 2017

theotherjimmy added needs: CI and removed needs: work labels Sep 7, 2017

0xc0170 added needs: work and removed needs: CI labels Oct 4, 2017

tung7970 force-pushed the fix-tools branch from 4a05375 to 926de7a Compare October 9, 2017 14:21

rtl8195am - use TOOLCHAIN_PATHS to locate toolchain

7d6e66d

Use TOOLCHAIN_PATHS to locate toolchain binaries for users might set compiler paths, through mbed_settings.py, env vars, or system path. Signed-off-by: Tony Wu <[email protected]>

tung7970 force-pushed the fix-tools branch from 926de7a to 7d6e66d Compare October 9, 2017 15:38

theotherjimmy added needs: review and removed needs: work labels Oct 9, 2017

0xc0170 added needs: CI and removed needs: review labels Oct 19, 2017

adbridge added ready for merge release-version: 5.6.3 and removed needs: CI labels Oct 20, 2017

adbridge merged commit e9e0595 into ARMmbed:master Oct 20, 2017

adbridge removed the ready for merge label Oct 20, 2017

RTL8195AM - Respect Toolchains paths in post bulid script. #5042

RTL8195AM - Respect Toolchains paths in post bulid script. #5042

Uh oh!

Conversation

tung7970 commented Sep 7, 2017 • edited by 0xc0170 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Related PRs

Todos

Deploy notes

Steps to test or reproduce

Uh oh!

bulislaw commented Sep 7, 2017

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

tung7970 commented Sep 7, 2017

Uh oh!

tung7970 commented Sep 7, 2017

Uh oh!

theotherjimmy commented Sep 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tung7970 commented Sep 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

theotherjimmy commented Sep 7, 2017

Uh oh!

0xc0170 commented Sep 27, 2017

Uh oh!

studavekar commented Sep 28, 2017

Uh oh!

mbed-bot commented Sep 28, 2017

Output

Uh oh!

theotherjimmy commented Oct 2, 2017

Uh oh!

tung7970 commented Oct 3, 2017

Uh oh!

0xc0170 commented Oct 9, 2017

Uh oh!

tung7970 commented Oct 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Oct 9, 2017

Uh oh!

mbed-ci commented Oct 9, 2017

Uh oh!

0xc0170 commented Oct 10, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

mbed-ci commented Oct 19, 2017

Uh oh!

studavekar commented Oct 19, 2017

Uh oh!

mbed-ci commented Oct 20, 2017

Uh oh!

Uh oh!

tung7970 commented Sep 7, 2017 •

edited by 0xc0170

Loading

theotherjimmy commented Sep 7, 2017 •

edited

Loading

tung7970 commented Oct 9, 2017 •

edited

Loading