Skip to content

Support VK_RZ_A1H with ds5 & e2studio exporters #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

Support VK_RZ_A1H with ds5 & e2studio exporters #5052

merged 1 commit into from
Sep 29, 2017
+2 −0

Conversation

mbedNoobNinja
Copy link
Contributor

Notes:

  • This is the PR supposed to fix the ds5 & e2studio exporters. but I very much doubt it will fix the online exporter issue.

Description

  • Online Project exporter persistently refuses to work. The details can be found in issue Export malfunction of mbed online compiler ! #3768, which obviously continues to be an issue.
  • No information for used RAM and ROM in the online compiler, when compiling projects for VK_RZ_A1H platform.

Steps to test or reproduce

Try to export standard mbed_blinky project for platform VK_RZ_A1H with the online compiler (export option) for toolchains IAR or ds5 or e2studio.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 8, 2017

cc @theotherjimmy

@theotherjimmy
Copy link
Contributor

@mbedNoobNinja Nice! I'll review now.

theotherjimmy
theotherjimmy suggested changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on my question below?

targets/targets.json Outdated
@@ -2259,7 +2259,7 @@
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
"default_toolchain": "ARM",
"program_cycle_s": 2,
"device_has": ["ANALOGIN", "CAN", "ETHERNET", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_FC", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
"device_has": ["ANALOGIN", "CAN", "ETHERNET", "I2C", "I2CSLAVE", "I2C_ASYNCH", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "SPI", "SPISLAVE", "SPI_ASYNCH", "STDIO_MESSAGES"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it will be needed when the two targets (VK_RZ_A1H and RZ_A1H) are merged look here #4440

... after adding "I2C_ASYNCH", "SPI_ASYNCH" & "SERIAL_ASYNCH" interfaces as "device_has" ittems for the "VK_RZ_A1H" platform in targets.json, the errors disappeared and the test finally managed to run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but that should not be part of this PR, and instead part of another one.

Copy link
Contributor Author

@mbedNoobNinja mbedNoobNinja Sep 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it will be removed.

Copy link
Contributor Author

@mbedNoobNinja mbedNoobNinja Sep 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targets.json is reverted ! Happy ?

@theotherjimmy
Copy link
Contributor

Yup. Looks great!

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2017

/morph export-build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 162

All exports and builds passed!

@theotherjimmy theotherjimmy merged commit 1a04b0a into ARMmbed:master Sep 29, 2017
@theotherjimmy theotherjimmy changed the title ds5 & e2studio export fix Support VK_RZ_A1H with ds5 & e2studio exporters Sep 29, 2017
@mbedNoobNinja mbedNoobNinja deleted the Branch_Export branch October 6, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbedNoobNinja @0xc0170 @theotherjimmy @mbed-bot