Skip to content

Move clock() function from mbed_rtc_time.cpp to mbed_retarget.cpp. #5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Sep 14, 2017

Description

Move clock() function from mbed_rtc_time.cpp to mbed_retarget.cpp as this is more suitable place for this function.
This PR is a result of discussion from PR#5087:

There is no information in documentation neither header file about clock() function. Maybe this function should be removed? It is used nowhere and it looks like this is not API.

I think it's a implementation of standard library function, maybe it's not the best place for it, you could try opening new PR and moving it to mbed_retarget.cpp.

Status

READY

Migrations

NO

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move looks good, I would probably fix the code style if we are moving it :-)

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2017

cc @c1728p9

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2017

cc @c1728p9

@bulislaw

@bulislaw
Copy link
Member

@mprse Could you also fix the coding style as suggested by Martin.

@mprse mprse force-pushed the move_clock_function branch from ba4571d to 035c089 Compare September 27, 2017 13:33
@mprse
Copy link
Contributor Author

mprse commented Sep 27, 2017

Hopefully fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2017

👍

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2017

/morph test

1 similar comment
@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1415

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants