Asm versions of netstack memcpy() and lwip_standard_chksum() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tests such as TCPEchoServer (http://mbed.org/users/emilmont/notebook/networking-libraries-benchmark/) this change showed a 28% improvement (14Mbps to 18Mbps) when the echo test was modified to instead use 1K data buffers. I targetted these two functions based on manual profiling samples which showed that a great deal of time was being spent in these two functions when the network stack was being slammed with UDP packets.
bogdanm
added a commit
that referenced
this pull request
Sep 2, 2013
Asm versions of netstack memcpy() and lwip_standard_chksum() [Note] I'm generally a bit reluctant when including optimizations like this (from an architectural standpoint), because they tend to be a bit too specific (for example, this one works only with lwIP+GCC+Cortex-M3 or M4), but for now it looks as this is the right place for them, although the optimized memcpy should ideally be in libc (or even better replaced with a DMA transfer in this particular case). But this will be both a nice optimization and a reminder of what we need to implement/change in the future.
|
Thanks. |
bridadan
pushed a commit
that referenced
this pull request
Jun 21, 2016
Exporters - virtual dirs support for progen exporters
cmonr
pushed a commit
that referenced
this pull request
May 24, 2018
BLE: Fix wrong macro name for IAR
linlingao
added a commit
to linlingao/mbed-os
that referenced
this pull request
Jul 12, 2019
Add rtc_api.c. RTC is not added to targets.json because the RTC can n…
Jookia
pushed a commit
to Jookia/mbed-os
that referenced
this pull request
Mar 11, 2023
…un not being on PATH causing all tests to pass! (ARMmbed#51) * Print the command when a greentea test is being run. Also fix mbedhtrun not being on PATH causing all tests to pass! * Also remove useless -f argument to mbedhtrun (not used with --skip-flashing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just targeted the GCC_ARM toolchain with these changes to minimize
risk. For the same reason, I only targeted this memcpy() to be used by
the network stack.
For tests such as TCPEchoServer
(http://mbed.org/users/emilmont/notebook/networking-libraries-benchmark/)
this change showed a 28% improvement (14Mbps to 18Mbps) when the echo
test was modified to instead use 1K data buffers.
I targetted these two functions based on manual profiling samples which
showed that a great deal of time was being spent in these two functions
when the network stack was being slammed with UDP packets.