-
Notifications
You must be signed in to change notification settings - Fork 3k
Cortex-M33: Add RTX5 context switcher files #5105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What version does it include (or only develop for now) ? Just wondering if we are taking this as separate patch as it is, or we should update (we already experienced some issues/improvements that are in the cmsis rtos released version but not in our codebase) |
@0xc0170 - I am not sure what is the process to add cmsis releases into our codebase. This files I am adding are part of cortex-m23/m33 support. Files related to cortex-m23 are already pushed in and tool changes were done for both m-23/m-33. |
@deepikabhavnani when is that needed for? I want to update CMSIS just after 5.6 is out. |
@bulislaw - Files are for cortex mainline processors, at present we do not hardware to test. But adding them separately because
You can review these after updating CMSIS, or just pick up this change along with update. I am fine with anything. |
@deepikabhavnani should we contribute it to CMSIS then? |
@bulislaw - I have PR ARM-software/CMSIS_5#226 to add IAR baseline specific files to CMSIS, once it is approved I can add mainline as well. It is not approved because Non-Secure and Secure code is duplicated in assembly files. Best solution is to have pre-processor defines (which are not supported in CMSIS). Conditional statements used in GCC/ARM assembly are not available in IAR assembly. |
Ok, if the form we have it in this PR is correct I'm guessing we can merge it and in the future overwrite it with whats going to get committed to CMSIS. Please don't forget to update docs with additions/modifications to CMSIS/RTX: |
@deepikabhavnani Can you update the md file ? We can then trigger CI |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
RTX5 context switcher files from RTX5 added to mbed-os code, Required to support ARMv8-Mainline architecture.