Skip to content

Cortex-M33: Add RTX5 context switcher files #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

deepikabhavnani
Copy link

RTX5 context switcher files from RTX5 added to mbed-os code, Required to support ARMv8-Mainline architecture.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2017

RTX5 context switcher files from RTX5 added to mbed-os code, Required to support ARMv8-Mainline architecture.

What version does it include (or only develop for now) ? Just wondering if we are taking this as separate patch as it is, or we should update (we already experienced some issues/improvements that are in the cmsis rtos released version but not in our codebase)

@deepikabhavnani
Copy link
Author

@0xc0170 - I am not sure what is the process to add cmsis releases into our codebase. This files I am adding are part of cortex-m23/m33 support. Files related to cortex-m23 are already pushed in and tool changes were done for both m-23/m-33.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2017

cc @bulislaw @c1728p9

@bulislaw
Copy link
Member

@deepikabhavnani when is that needed for? I want to update CMSIS just after 5.6 is out.

@deepikabhavnani
Copy link
Author

@bulislaw - Files are for cortex mainline processors, at present we do not hardware to test. But adding them separately because

  1. IAR specific files are missing in CMSIS
  2. Pre-processing macro changes (as aligned to other assembly files)

You can review these after updating CMSIS, or just pick up this change along with update. I am fine with anything.

@bulislaw
Copy link
Member

@deepikabhavnani should we contribute it to CMSIS then?

@deepikabhavnani
Copy link
Author

@bulislaw - I have PR ARM-software/CMSIS_5#226 to add IAR baseline specific files to CMSIS, once it is approved I can add mainline as well.

It is not approved because Non-Secure and Secure code is duplicated in assembly files. Best solution is to have pre-processor defines (which are not supported in CMSIS). Conditional statements used in GCC/ARM assembly are not available in IAR assembly.

@bulislaw
Copy link
Member

Ok, if the form we have it in this PR is correct I'm guessing we can merge it and in the future overwrite it with whats going to get committed to CMSIS. Please don't forget to update docs with additions/modifications to CMSIS/RTX:
https://github.com/ARMmbed/Handbook/blob/5.5/docs/advanced/cmsis-rtos.md

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 28, 2017

@deepikabhavnani Can you update the md file ? We can then trigger CI

@deepikabhavnani
Copy link
Author

@bulislaw @0xc0170 update the md file, please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1438

All builds and test passed!

@theotherjimmy theotherjimmy changed the title [Cortex-M33] Added RTX5 context switcher files [Cortex-M33] Add RTX5 context switcher files Sep 29, 2017
@theotherjimmy theotherjimmy changed the title [Cortex-M33] Add RTX5 context switcher files Cortex-M33: Add RTX5 context switcher files Oct 2, 2017
@theotherjimmy theotherjimmy merged commit 9345901 into ARMmbed:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants