RTL8195AM - Fix us_ticker porting #5143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung7970
force-pushed
the
fix-lockup
branch
from
11549cf to
f6d6241
Compare
commit f7bc126 (Re-work Rtl8195AM ticker) tried to address ticker drifting issue, but in fact broke ticker functionality. This patch adjusts us_ticker porting to unbreak it, and to fix the following tests: mbed-os-tests-mbed_drivers-ticker mbed-os-tests-mbed_drivers-timeout mbed-os-tests-mbedmicro-rtos-mbed-isr mbed-os-features-frameworks-utest-tests-unit_tests-minimal_async_scheduler mbed-os-features-frameworks-utest-tests-unit_tests-case_control_async mbed-os-features-frameworks-utest-tests-unit_tests-case_async_validate Changes are: 1. Dont disable timer after every us_ticker interrupt. That basically breaks ticker functionality. 2. Fine-tune us to tick conversion macro. Previous conversion method yields 1 tick drift every 2 ms. 3. Remove special placement of ticker objects. No longer necessary. Signed-off-by: Tony Wu <[email protected]>
tung7970
force-pushed
the
fix-lockup
branch
from
f6d6241 to
6c11678
Compare
0xc0170
approved these changes
Sep 20, 2017
|
How was this tested? run tests that you can share the results? |
|
Hi @0xc0170 , I found previous PR could not pass driver_ticker test in Greentea. So I just ran Greentea test on this branch with GCC and ARM and IAR. All tests passed. Here's the result with GCC |
|
Like @Archcady mentioned, without this patch, ticker and timeout related greentea tests will fail. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
commit f7bc126 (Re-work Rtl8195AM ticker) tried to address ticker drifting issue, but in
fact broke ticker functionality.This patch adjusts us_ticker porting to un-break it, and to fix the following tests:
Changes are:
Dont disable timer after every us_ticker interrupt. That basically
breaks ticker functionality.
Fine-tune us to tick conversion macro. Previous conversion method
yields 1 tick drift every 2 ms.
Remove special placement of ticker objects. No longer necessary.
Status
READY
Migrations
NO
Related PRs
#5044
Todos
NONE
Deploy notes
NONE
Steps to test or reproduce
mbed greentea test