tools/toolhains - Test for flag passing in constructor #5182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Sep 26, 2017
0xc0170
reviewed
Sep 26, 2017
tools/test/toolchains/api_test.py
Outdated
| assert compile_cmd, to_compile | ||
| for parameter in profile['ld']: | ||
| print(any(parameter in cmd[0][0] for cmd in compile_cmd)) | ||
| assert True |
There was a problem hiding this comment.
Yep. but harmless.
theotherjimmy
force-pushed
the
test-flags-assumptions
branch
from
7e29cb6 to
b9b4bb5
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata
Fixes #5181
Descirption
This PR moves the passing of ld flags when compiling with
IARto theconstructor.
This PR also adds tests that certify that all toolchains pass all
arguments from their build profiles both:
This is stronger than the prior guarantee, which was: The compilers (C,
C++, Assembler) all pass their build profile arguments to the command
line invocation.
Testing