Skip to content

NUCLEO_F207ZG: Analogout improvement #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2017
Merged

NUCLEO_F207ZG: Analogout improvement #5188

merged 3 commits into from
Oct 23, 2017

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Sep 25, 2017 •
edited
Loading

Description

  • Align the code with the STM32F0 devices.
  • Add initialization of the obj->handle.State variable (this solves the tests-api-analogout GCC_ARM issue)

Status

READY

Migrations

NO

ST_INTERNAL_REF 36562

0xc0170
0xc0170 reviewed Sep 25, 2017
View reviewed changes
targets/TARGET_STM/TARGET_STM32F2/analogout_device.c Outdated
void analogout_init(dac_t *obj, PinName pin)
{
DAC_ChannelConfTypeDef sConfig;
void analogout_init(dac_t *obj, PinName pin) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this code style change?

@bcostm
Copy link
Contributor Author

bcostm commented Sep 26, 2017

There is another thing to make this test pass for GCC. I close this PR until a solution is found.

@bcostm bcostm closed this Sep 26, 2017
@sg- sg- removed the needs: work label Sep 26, 2017
@bcostm bcostm reopened this Oct 5, 2017
@bcostm bcostm changed the title NUCLEO_F207ZG: Fix issue with tests-api-analogout and GCC_ARM NUCLEO_F207ZG: Analogout improvement Oct 5, 2017
@bcostm
Copy link
Contributor Author

bcostm commented Oct 5, 2017

Everything is OK now on my side.

This was referenced Oct 5, 2017
Merged
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 10, 2017

retest uvisor

0xc0170
0xc0170 reviewed Oct 10, 2017
View reviewed changes
targets/TARGET_STM/TARGET_STM32F2/analogout_device.c Outdated
{
}

void analogout_free(dac_t *obj) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix please { - new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2017

Build : FAILURE

Build number : 52
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5188/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2017

Build : SUCCESS

Build number : 268
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5188/

Skipping test trigger, missing label 'NEED CI'

@studavekar
Copy link
Contributor

This was triggered with needs: CI , as label is added re-triggering the job
/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2017

Build : SUCCESS

Build number : 283
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5188/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2017

Test : SUCCESS

Build number : 129
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5188/129

@adbridge
Copy link
Contributor

@0xc0170 are you happy with this after the review changes ?

theotherjimmy
theotherjimmy approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by @0xc0170

@theotherjimmy theotherjimmy merged commit 3354327 into ARMmbed:master Oct 23, 2017
@bcostm bcostm deleted the fix_dac_f207zg branch January 24, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bcostm @0xc0170 @mbed-ci @studavekar @adbridge @theotherjimmy @sg-